Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disabling/Hiding features when offline #4415

Merged
merged 4 commits into from
Nov 21, 2024
Merged

Disabling/Hiding features when offline #4415

merged 4 commits into from
Nov 21, 2024

Conversation

rapterjet2004
Copy link
Contributor

@rapterjet2004 rapterjet2004 commented Nov 4, 2024 •
edited
Loading

🚧 TODO

  • Message Actions
  • Search
  • Create Conversation
  • Create Account
  • File sharing and voice recording
  • calling
  • Conversation Actions
  • ...

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@rapterjet2004 rapterjet2004 added 2. developing Work in progress 3. to review Waiting for reviews and removed 2. developing Work in progress labels Nov 6, 2024
@rapterjet2004 rapterjet2004 requested a review from mahibi November 6, 2024 13:34
@rapterjet2004 rapterjet2004 force-pushed the issue-4376-hide-features-in-offline-mode branch from c81c585 to e0c0ea0 Compare November 13, 2024 16:42
@mahibi mahibi force-pushed the issue-4376-hide-features-in-offline-mode branch from bca36b5 to 68ce6fa Compare November 21, 2024 09:18
@mahibi mahibi enabled auto-merge November 21, 2024 09:18
@github-actions GitHub Actions
Copy link
Contributor

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/4415-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

@mahibi mahibi merged commit 6637e8c into master Nov 21, 2024
15 of 17 checks passed
@mahibi mahibi deleted the issue-4376-hide-features-in-offline-mode branch November 21, 2024 09:32
@github-actions GitHub Actions
Copy link
Contributor

Codacy

Lint

TypemasterPR
Warnings94154
Errors13281

SpotBugs

CategoryBaseNew
Bad practice66
Correctness1616
Dodgy code7474
Internationalization33
Malicious code vulnerability33
Performance55
Security11
Total108108

Lint increased!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mahibi mahibi mahibi approved these changes

Assignees
No one assigned
Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

hide features in offline mode
2 participants
@rapterjet2004 @mahibi