Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore user status #4392

Merged
merged 21 commits into from
Nov 14, 2024
Merged

Restore user status #4392

merged 21 commits into from
Nov 14, 2024

Conversation

sowjanyakch
Copy link
Contributor

@sowjanyakch sowjanyakch commented Oct 30, 2024 •
edited
Loading

Resolve #2943

To test this PR:

  1. Set a status.
  2. Start a call.
  3. The status is automatically set to "In a call" when you are in call.
  4. You can see the previously set status in the predefined status list and clicking on "Reset status" button should revert the status and close the status dialog.
Screenshot 2024-11-08 at 19 43 30

🚧 TODO

  • ...

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@sowjanyakch sowjanyakch force-pushed the restore_user_status branch 2 times, most recently from 294f7bf to e2ae181 Compare November 8, 2024 16:18
@sowjanyakch sowjanyakch self-assigned this Nov 8, 2024
@sowjanyakch sowjanyakch added the 3. to review Waiting for reviews label Nov 8, 2024
@sowjanyakch sowjanyakch marked this pull request as ready for review November 8, 2024 19:07
@sowjanyakch sowjanyakch requested a review from mahibi November 11, 2024 14:55
@github-actions GitHub Actions
Copy link
Contributor

Codacy

Lint

TypemasterPR
Warnings94153
Errors13289

SpotBugs

CategoryBaseNew
Bad practice66
Correctness1616
Dodgy code7474
Internationalization33
Malicious code vulnerability33
Performance55
Security11
Total108108

Lint increased!

@sowjanyakch
add backupStatus endpoint
6589889 
Signed-off-by: sowjanyakch <[email protected]>
@sowjanyakch
create url for backup status
8cd8c5c 
Signed-off-by: sowjanyakch <[email protected]>
@sowjanyakch
modify predefined_status.xml
2aac51d 
Signed-off-by: sowjanyakch <[email protected]>
@sowjanyakch
add reset button
9f7c899 
Signed-off-by: sowjanyakch <[email protected]>
@sowjanyakch
show reset button on first item of recycler view
6a9211e 
Signed-off-by: sowjanyakch <[email protected]>
@sowjanyakch
add capability for restore
5fe5931 
Signed-off-by: sowjanyakch <[email protected]>
@sowjanyakch
test backupStatus endpoint
27aafda 
Signed-off-by: sowjanyakch <[email protected]>
@sowjanyakch
add backup message in the predefined status list
d08b4f5 
Signed-off-by: sowjanyakch <[email protected]>
@sowjanyakch
get backup status only if restore capability is available
974da71 
Signed-off-by: sowjanyakch <[email protected]>
@sowjanyakch
add elements to predefinedStatusesList correctly
ec01a04 
Signed-off-by: sowjanyakch <[email protected]>
@sowjanyakch
handle reset status button
9fbb388 
Signed-off-by: sowjanyakch <[email protected]>
@sowjanyakch
format
7a63a64 
Signed-off-by: sowjanyakch <[email protected]>
@sowjanyakch
check for capability before reverting status
c4f4c85 
Signed-off-by: sowjanyakch <[email protected]>
@sowjanyakch
remove redundant null check
13208e8 
Signed-off-by: sowjanyakch <[email protected]>
@sowjanyakch
add hint - your status was set automatically
3f74a44 
Signed-off-by: sowjanyakch <[email protected]>
@sowjanyakch
reset status and hide the dialog
fbecfaf 
Signed-off-by: sowjanyakch <[email protected]>
@sowjanyakch
remove Snackbar
05ca7f5 
Signed-off-by: sowjanyakch <[email protected]>
@sowjanyakch
use const val HTTP_STATUS_CODE_OK
dba3034 
Signed-off-by: sowjanyakch <[email protected]>
@sowjanyakch
handle disposable properly
2c6daed 
Signed-off-by: sowjanyakch <[email protected]>
@sowjanyakch
error handling
92caa21 
Signed-off-by: sowjanyakch <[email protected]>
@sowjanyakch
ktlintFormat
b558a71 
Signed-off-by: sowjanyakch <[email protected]>
@github-actions GitHub Actions
Copy link
Contributor

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/4392-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

@sowjanyakch sowjanyakch merged commit b361d56 into master Nov 14, 2024
14 of 16 checks passed
@sowjanyakch sowjanyakch deleted the restore_user_status branch November 14, 2024 16:44
@mahibi
Copy link
Collaborator

mahibi commented Nov 26, 2024

/backport to stable-20.0

@backportbot backportbot bot mentioned this pull request Nov 26, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mahibi mahibi mahibi approved these changes

@rapterjet2004 rapterjet2004 Awaiting requested review from rapterjet2004

Assignees

@sowjanyakch sowjanyakch

Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support "Restore user status"
2 participants
@sowjanyakch @mahibi