fix messages not shown + improve unread marker behavior #4390
+93
−120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mahibi
force-pushed
the
bugfix/4380/fixMessagesNotShownAndImproveUnreadMarker
branch
from
d089dc7 to
67605bd
Compare
mahibi
force-pushed
the
bugfix/4380/fixMessagesNotShownAndImproveUnreadMarker
branch
from
67605bd to
22c09c2
Compare
mahibi
added
3. to review
|
/backport to stable-20.0 |
sowjanyakch
approved these changes
Nov 5, 2024
this commit will avoid to fail to show messages in adapter. This was caused by the usage of
messagesListAdapter.deleteById("-1");
in UnreadNoticeMessageViewHolder.
The bug seems to exist in the past already but was never reported (Sometimes, when receiving a lot of messages it could happen that some message in between is not shown in UI). However with recent changes after release 20.0.2 the bug appeared more often.
The root cause was not analyzed, but the handling was modified in general as the unread marker behavior was never really good.
By not using deleteById but replace it with new unread marker logic, the bug of disappearing messages is solved and the unread messages marker behavior is improved.
Signed-off-by: Marcel Hibbe <[email protected]>
replace com.nextcloud.ui.popupbubble.PopupBubble with MaterialButton. com.nextcloud.ui.popupbubble.PopupBubble was forked from https://github.com/webianks/PopupBubble which is quite outdated. com.nextcloud.ui.popupbubble.PopupBubble is still used in ConversationsListActivity but there it should also be removed. Removing this recycler view stuff will also help a bit to switch to JetpackCompose Signed-off-by: Marcel Hibbe <[email protected]>
Signed-off-by: Marcel Hibbe <[email protected]>
Signed-off-by: Marcel Hibbe <[email protected]>
mahibi
force-pushed
the
bugfix/4380/fixMessagesNotShownAndImproveUnreadMarker
branch
from
22c09c2 to
ff90552
Compare
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/4390-talk.apk |
mahibi
deleted the
bugfix/4380/fixMessagesNotShownAndImproveUnreadMarker
branch
2 tasks
|
/backport to stable-20.0 |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #4380
also:
🖼️ Screen video
PR4390.mp4
🏁 Checklist
/backport to stable-xx.x