Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

User now knows if no offline messages are saved when entering a conversation #4389

Merged
merged 2 commits into from
Dec 3, 2024
Merged

User now knows if no offline messages are saved when entering a conversation #4389

merged 2 commits into from
Dec 3, 2024

Conversation

rapterjet2004
Copy link
Contributor

@rapterjet2004 rapterjet2004 commented Oct 28, 2024 •
edited by mahibi
Loading

Screenshot 2024-11-13 at 7 59 29 AM

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@rapterjet2004 rapterjet2004 added the 3. to review Waiting for reviews label Oct 28, 2024
@rapterjet2004 rapterjet2004 force-pushed the issue-4377-show-no-msg-saved branch from 44988db to d78666d Compare October 28, 2024 13:45
mahibi

This comment was marked as resolved.

Sign in to view

@rapterjet2004 rapterjet2004 force-pushed the issue-4377-show-no-msg-saved branch from 7b9f942 to 2534261 Compare November 12, 2024 14:36
@rapterjet2004 rapterjet2004 requested a review from mahibi November 12, 2024 14:40
@rapterjet2004 rapterjet2004 force-pushed the issue-4377-show-no-msg-saved branch from 2534261 to b0f4043 Compare November 14, 2024 13:27
@mahibi

This comment was marked as resolved.

Sign in to view
@rapterjet2004 rapterjet2004 force-pushed the issue-4377-show-no-msg-saved branch from 851bc9f to 8e5fd30 Compare November 29, 2024 17:23
@mahibi mahibi force-pushed the issue-4377-show-no-msg-saved branch from 8e5fd30 to 3cb67e4 Compare December 2, 2024 11:42
@mahibi mahibi enabled auto-merge December 2, 2024 11:42
@mahibi mahibi force-pushed the issue-4377-show-no-msg-saved branch from 3cb67e4 to 5d3664a Compare December 3, 2024 09:22
@mahibi mahibi added this to the 21.0.0 milestone Dec 3, 2024
@mahibi
Copy link
Collaborator

mahibi commented Dec 3, 2024

/backport to stable-20.1

@mahibi
fix Duplicate ids in xml
a0d6442 
Signed-off-by: Marcel Hibbe <[email protected]>
@mahibi mahibi force-pushed the issue-4377-show-no-msg-saved branch from 5d3664a to a0d6442 Compare December 3, 2024 09:37
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 3, 2024

Codacy

Lint

TypemasterPR
Warnings158158
Errors7373

SpotBugs

CategoryBaseNew
Bad practice66
Correctness1616
Dodgy code7171
Internationalization33
Malicious code vulnerability33
Performance44
Security11
Total104104

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 3, 2024

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/4389-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

@mahibi mahibi merged commit ff74202 into master Dec 3, 2024
18 checks passed
@mahibi mahibi deleted the issue-4377-show-no-msg-saved branch December 3, 2024 09:51
@backportbot backportbot bot mentioned this pull request Dec 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mahibi mahibi mahibi approved these changes

@sowjanyakch sowjanyakch Awaiting requested review from sowjanyakch

Assignees

@rapterjet2004 rapterjet2004

Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
21.0.0
Development

Successfully merging this pull request may close these issues.

Info about "No offline messages available"
2 participants
@rapterjet2004 @mahibi