Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Last moderator should not leave the room #4360

Merged
merged 11 commits into from
Nov 5, 2024
Merged

Last moderator should not leave the room #4360

merged 11 commits into from
Nov 5, 2024

Conversation

sowjanyakch
Copy link
Contributor

@sowjanyakch sowjanyakch commented Oct 22, 2024 •
edited
Loading

resolve #490

🖼️ Screenshots

Screenshot 2024-10-28 at 09 21 09

🚧 TODO

  • ...

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@sowjanyakch sowjanyakch force-pushed the last_moderator_should_delete_room branch 3 times, most recently from 02e0519 to af19696 Compare October 28, 2024 07:58
@sowjanyakch sowjanyakch marked this pull request as ready for review October 28, 2024 08:23
@sowjanyakch sowjanyakch self-assigned this Oct 28, 2024
@sowjanyakch sowjanyakch added the 3. to review Waiting for reviews label Oct 28, 2024
@sowjanyakch sowjanyakch changed the title Last moderator should delete room Last moderator should not leave the room Oct 28, 2024
@sowjanyakch sowjanyakch force-pushed the last_moderator_should_delete_room branch from af19696 to 09f6a5f Compare October 29, 2024 15:57
@sowjanyakch sowjanyakch requested a review from mahibi October 29, 2024 15:59
@sowjanyakch sowjanyakch force-pushed the last_moderator_should_delete_room branch from e476294 to e58760c Compare October 29, 2024 16:34
@sowjanyakch
Copy link
Contributor Author

/backport to stable-20.0

sowjanyakch and others added 11 commits November 5, 2024 14:53
@sowjanyakch @mahibi
Rename .java to .kt
be55a90 
Signed-off-by: sowjanyakch <[email protected]>
@sowjanyakch @mahibi
Convert LeaveConversationWorker from java to Kotlin
f6824f9 
Signed-off-by: sowjanyakch <[email protected]>
@sowjanyakch @mahibi
remove unused imports
e04f236 
Signed-off-by: sowjanyakch <[email protected]>
@sowjanyakch @mahibi
Start unique work
088e6fd 
Signed-off-by: sowjanyakch <[email protected]>
@sowjanyakch @mahibi
handle workResult
aa5fd42 
Signed-off-by: sowjanyakch <[email protected]>
@sowjanyakch @mahibi
make worker listenable
a07a544 
Signed-off-by: sowjanyakch <[email protected]>
@sowjanyakch @mahibi
refresh main activity after leaving a conversation
9df91b6 
Signed-off-by: sowjanyakch <[email protected]>
@sowjanyakch @mahibi
ktlintFormat
f6489eb 
Signed-off-by: sowjanyakch <[email protected]>
@sowjanyakch @mahibi
handle errors properly
6c4685d 
Signed-off-by: sowjanyakch <[email protected]>
@sowjanyakch @mahibi
add const val for error code
a39ca25 
Signed-off-by: sowjanyakch <[email protected]>
@mahibi
set nc_last_moderator_leaving_room_warning to one line in strings.xml
2ad8c2e 
Signed-off-by: Marcel Hibbe <[email protected]>
@mahibi mahibi force-pushed the last_moderator_should_delete_room branch from e58760c to 2ad8c2e Compare November 5, 2024 14:02
@mahibi mahibi enabled auto-merge November 5, 2024 14:02
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 5, 2024

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/4360-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 5, 2024

Codacy

Lint

TypemasterPR
Warnings94152
Errors13289

SpotBugs

CategoryBaseNew
Bad practice66
Correctness1111
Dodgy code7978
Internationalization33
Malicious code vulnerability33
Performance66
Security11
Total109108

Lint increased!

@mahibi mahibi merged commit f48c33d into master Nov 5, 2024
15 of 18 checks passed
@mahibi mahibi deleted the last_moderator_should_delete_room branch November 5, 2024 14:29
@backportbot backportbot bot mentioned this pull request Nov 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mahibi mahibi mahibi approved these changes

@rapterjet2004 rapterjet2004 Awaiting requested review from rapterjet2004

Assignees

@sowjanyakch sowjanyakch

Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Show error when last moderator tries to leave a room
2 participants
@sowjanyakch @mahibi