Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Queuing offline messages to be sent online #4183

Merged
merged 2 commits into from
Sep 13, 2024
Merged

Queuing offline messages to be sent online #4183

merged 2 commits into from
Sep 13, 2024

Conversation

rapterjet2004
Copy link
Contributor

@rapterjet2004 rapterjet2004 commented Sep 10, 2024 •
edited
Loading

🖼️ Screenshots

🚧 TODO

  • Got it working
  • Add counter to tally message queue size
    • persist UI state on lifecycle changes -_-
  • linter and test

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@rapterjet2004 rapterjet2004 marked this pull request as ready for review September 12, 2024 14:54
@rapterjet2004
Copy link
Contributor Author

/backport to stable-20.0

rapterjet2004 and others added 2 commits September 13, 2024 15:27
@rapterjet2004 @mahibi
Implement queued messages for offline support
569be55 
Signed-off-by: rapterjet2004 <[email protected]>
@mahibi
fix order of queued messages
dc32a4a 
add delay between sending of queued messages to increase the chance they are received on server in the correct order. This is not the best solution though as it blocks the UI a bit so may have to be improved!

Signed-off-by: Marcel Hibbe <[email protected]>
@mahibi mahibi force-pushed the issue-4167-send-messages-offline branch from 5efc67d to dc32a4a Compare September 13, 2024 13:28
@mahibi mahibi added this to the 20.1.0 milestone Sep 13, 2024
@mahibi mahibi merged commit 4517ca5 into master Sep 13, 2024
13 of 17 checks passed
@mahibi mahibi deleted the issue-4167-send-messages-offline branch September 13, 2024 13:29
@backportbot backportbot bot mentioned this pull request Sep 13, 2024
Merged
@github-actions GitHub Actions
Copy link
Contributor

Codacy

Lint

TypemasterPR
Warnings8694
Errors131131

SpotBugs

CategoryBaseNew
Bad practice66
Correctness1111
Dodgy code7878
Internationalization33
Malicious code vulnerability33
Performance66
Security11
Total108108

Lint increased!

@github-actions GitHub Actions
Copy link
Contributor

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/4183-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

@nextcloud nextcloud deleted a comment from backportbot bot Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mahibi mahibi mahibi approved these changes

Assignees

@rapterjet2004 rapterjet2004

Labels
backport-request
Projects
None yet
Milestone
20.1.0
Development

Successfully merging this pull request may close these issues.

Send messages that were written when being offline
2 participants
@rapterjet2004 @mahibi