Bugfix/3993/fix flickering unread mention popup #4177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/backport to stable-20.0 |
sowjanyakch
approved these changes
Sep 11, 2024
bug was introduced with #3417 Signed-off-by: Marcel Hibbe <[email protected]>
…ists Signed-off-by: Marcel Hibbe <[email protected]>
… null same for swipeRefreshLayoutView?.isRefreshing If searchHelper would be null (= when UnifiedSearch is not available) then going back to conversations list view would not trigger to check to show for unread mentions bubble. This fix will make it independent from searchHelper. Signed-off-by: Marcel Hibbe <[email protected]>
… button ...instead to just show it on top Signed-off-by: Marcel Hibbe <[email protected]>
sowjanyakch
force-pushed
the
bugfix/3993/fixFlickeringUnreadMentionPopup
branch
from
a19141e to
6ddf06e
Compare
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/4177-talk.apk |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #3993
also: improve "scroll to" position. fix logic with unifiedSearch Availability
🏁 Checklist
/backport to stable-xx.x