Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove conductor #3436

Merged
merged 2 commits into from
Nov 23, 2023
Merged

Remove conductor #3436

merged 2 commits into from
Nov 23, 2023

Conversation

mahibi
Copy link
Collaborator

@mahibi mahibi commented Nov 8, 2023 •
edited
Loading

resolve #1551

This is the final PR to remove conductor.

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@mahibi mahibi self-assigned this Nov 8, 2023
@mahibi mahibi force-pushed the refactoring/noid/removeConductor branch 3 times, most recently from 4e162ee to c7683f3 Compare November 20, 2023 17:05
@mahibi mahibi mentioned this pull request Nov 20, 2023
Merged
6 tasks
@mahibi mahibi force-pushed the refactoring/noid/removeConductor branch 4 times, most recently from 7f71c92 to 5aa4314 Compare November 23, 2023 09:31
@mahibi mahibi changed the title WIP replace controllers with activities Remove conductor Nov 23, 2023
@mahibi mahibi added this to the 18.0.0 milestone Nov 23, 2023
@mahibi mahibi marked this pull request as ready for review November 23, 2023 09:37
mahibi and others added 2 commits November 23, 2023 13:26
@mahibi
remove conductor
591d6dc 
- replace remaining controllers with activities
- remove conductor lib
- modify some code related to account management and conductor

Signed-off-by: Marcel Hibbe <[email protected]>
@mahibi
Analysis: update lint results to reflect reduced error/warning count
0634dbd 
Signed-off-by: github-actions <[email protected]>
@mahibi mahibi force-pushed the refactoring/noid/removeConductor branch from e3a4e0f to 0634dbd Compare November 23, 2023 12:26
@mahibi mahibi enabled auto-merge November 23, 2023 12:27
@github-actions GitHub Actions
Copy link
Contributor

Codacy

Lint

TypemasterPR
Warnings8985
Errors00

SpotBugs

CategoryBaseNew
Bad practice66
Correctness1010
Dodgy code123123
Internationalization55
Malicious code vulnerability33
Performance88
Security22
Total157157

@github-actions GitHub Actions
Copy link
Contributor

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/3436-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

@mahibi mahibi merged commit 3ad2ec5 into master Nov 23, 2023
16 checks passed
@delete-merged-branch delete-merged-branch bot deleted the refactoring/noid/removeConductor branch November 23, 2023 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

@rapterjet2004 rapterjet2004 Awaiting requested review from rapterjet2004

Assignees

@mahibi mahibi

Labels
None yet
Projects
None yet
Milestone
18.0.0
Development

Successfully merging this pull request may close these issues.

get rid of Conductor
2 participants
@mahibi @AndyScherzinger