Added Instrumentation Test and Unit Tests

[Smarshal21]

Added Instrumentation Test For VibrationUtils and Unit Tests for other files mentioned below.

• VibrationUtils
• BundleKeys
• UriUtils
• DataChannelMessageNotifier
• Globals
• PeerConnectionNotifier

[mahibi]

lgtm, thanks!

just as a reminder now that you use the original repo: to update the branch you can rebase on master instead to merge.

[mahibi]

@Smarshal21 if you want to have all checks green:

• "Check / check (ktlintCheck) (pull_request)"
  --> click on details which will show:

 > Task :app:ktlintTestSourceSetCheck FAILED
/home/runner/work/talk-android/talk-android/app/src/test/java/com/nextcloud/talk/utils/BundleKeysTest.kt:60:5 Declarations and declarations with annotations should have an empty space between.
/home/runner/work/talk-android/talk-android/app/src/test/java/com/nextcloud/talk/utils/BundleKeysTest.kt:83:22 Argument should be on a separate line (unless all arguments can fit a single line)
/home/runner/work/talk-android/talk-android/app/src/test/java/com/nextcloud/talk/utils/BundleKeysTest.kt:83:22 Missing newline after "("
/home/runner/work/talk-android/talk-android/app/src/test/java/com/nextcloud/talk/utils/BundleKeysTest.kt:84:67 Missing newline before ")"
/home/runner/work/talk-android/talk-android/app/src/test/java/com/nextcloud/talk/utils/BundleKeysTest.kt:84:68 Missing newline before ")"
/home/runner/work/talk-android/talk-android/app/src/test/java/com/nextcloud/talk/utils/BundleKeysTest.kt:85:22 Argument should be on a separate line (unless all arguments can fit a single line)
/home/runner/work/talk-android/talk-android/app/src/test/java/com/nextcloud/talk/utils/BundleKeysTest.kt:85:22 Missing newline after "("
/home/runner/work/talk-android/talk-android/app/src/test/java/com/nextcloud/talk/utils/BundleKeysTest.kt:86:67 Missing newline before ")"
/home/runner/work/talk-android/talk-android/app/src/test/java/com/nextcloud/talk/utils/BundleKeysTest.kt:86:68 Missing newline before ")"
/home/runner/work/talk-android/talk-android/app/src/test/java/com/nextcloud/talk/utils/UriUtilsTest.kt:29:1 First line in a method block should not be empty
/home/runner/work/talk-android/talk-android/app/src/test/java/com/nextcloud/talk/webrtc/PeerConnectionNotifierTest.kt:34:5 Declarations and declarations with annotations should have an empty space between.

• "DCO Action required after 1s — DCO"
  --> see https://github.com/nextcloud/talk-android/blob/master/CONTRIBUTING.md#sign-your-work

feel free to fix or ask if anything is unclear.

[Smarshal21]

@Smarshal21 if you want to have all checks green:

• "Check / check (ktlintCheck) (pull_request)"
  --> click on details which will show:

 > Task :app:ktlintTestSourceSetCheck FAILED
/home/runner/work/talk-android/talk-android/app/src/test/java/com/nextcloud/talk/utils/BundleKeysTest.kt:60:5 Declarations and declarations with annotations should have an empty space between.
/home/runner/work/talk-android/talk-android/app/src/test/java/com/nextcloud/talk/utils/BundleKeysTest.kt:83:22 Argument should be on a separate line (unless all arguments can fit a single line)
/home/runner/work/talk-android/talk-android/app/src/test/java/com/nextcloud/talk/utils/BundleKeysTest.kt:83:22 Missing newline after "("
/home/runner/work/talk-android/talk-android/app/src/test/java/com/nextcloud/talk/utils/BundleKeysTest.kt:84:67 Missing newline before ")"
/home/runner/work/talk-android/talk-android/app/src/test/java/com/nextcloud/talk/utils/BundleKeysTest.kt:84:68 Missing newline before ")"
/home/runner/work/talk-android/talk-android/app/src/test/java/com/nextcloud/talk/utils/BundleKeysTest.kt:85:22 Argument should be on a separate line (unless all arguments can fit a single line)
/home/runner/work/talk-android/talk-android/app/src/test/java/com/nextcloud/talk/utils/BundleKeysTest.kt:85:22 Missing newline after "("
/home/runner/work/talk-android/talk-android/app/src/test/java/com/nextcloud/talk/utils/BundleKeysTest.kt:86:67 Missing newline before ")"
/home/runner/work/talk-android/talk-android/app/src/test/java/com/nextcloud/talk/utils/BundleKeysTest.kt:86:68 Missing newline before ")"
/home/runner/work/talk-android/talk-android/app/src/test/java/com/nextcloud/talk/utils/UriUtilsTest.kt:29:1 First line in a method block should not be empty
/home/runner/work/talk-android/talk-android/app/src/test/java/com/nextcloud/talk/webrtc/PeerConnectionNotifierTest.kt:34:5 Declarations and declarations with annotations should have an empty space between.

• "DCO Action required after 1s — DCO"
  --> see https://github.com/nextcloud/talk-android/blob/master/CONTRIBUTING.md#sign-your-work

feel free to fix or ask if anything is unclear.

Sure

[github-actions]

Codacy

Lint

Type	master	PR
Warnings	93	93
Errors	0	0

SpotBugs

Category	Base	New
Correctness	9	9
Dodgy code	123	123
Internationalization	5	5
Malicious code vulnerability	3	3
Performance	8	8
Security	2	2
Total	150	150

[github-actions]

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/3310-talk.apk



To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

[github-actions]

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!