Skip to content

Commit

Permalink
Merge pull request #4446 from nextcloud/coroutine_2
Browse files Browse the repository at this point in the history 
Migrate Rxjava to coroutines #2
  • Loading branch information
@mahibi
mahibi authored Nov 18, 2024
2 parents 7d09747 + e5802d7 commit b748080
Show file tree
Hide file tree
Showing 8 changed files with 135 additions and 149 deletions.
24 changes: 0 additions & 24 deletions app/src/main/java/com/nextcloud/talk/api/NcApi.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -195,18 +195,6 @@ Observable<GenericOverall> demoteAttendeeFromModerator(@Header("Authorization")
@DELETE
Observable<GenericOverall> removeSelfFromRoom(@Header("Authorization") String authorization, @Url String url);

/*
Server URL is: baseUrl + ocsApiVersion + spreedApiVersion + /room/roomToken/public
*/
@POST
Observable<GenericOverall> makeRoomPublic(@Header("Authorization") String authorization, @Url String url);

/*
Server URL is: baseUrl + ocsApiVersion + spreedApiVersion + /room/roomToken/public
*/
@DELETE
Observable<GenericOverall> makeRoomPrivate(@Header("Authorization") String authorization, @Url String url);

@DELETE
Observable<GenericOverall> deleteRoom(@Header("Authorization") String authorization, @Url String url);

Expand Down Expand Up @@ -341,18 +329,6 @@ Observable<Unit> registerDeviceForNotificationsWithPushProxy(@Url String url,
Observable<Void> unregisterDeviceForNotificationsWithProxy(@Url String url,
@QueryMap Map<String, String> fields);

@FormUrlEncoded
@PUT
Observable<GenericOverall> setPassword(@Header("Authorization") String authorization,
@Url String url,
@Field("password") String password);

@FormUrlEncoded
@PUT
Observable<Response<GenericOverall>> setPassword2(@Header("Authorization") String authorization,
@Url String url,
@Field("password") String password);

@GET
Observable<CapabilitiesOverall> getCapabilities(@Header("Authorization") String authorization, @Url String url);

Expand Down
12 changes: 10 additions & 2 deletions app/src/main/java/com/nextcloud/talk/api/NcApiCoroutines.kt
View file
Original file line number Diff line number Diff line change
Expand Up @@ -89,10 +89,10 @@ interface NcApiCoroutines {
): AddParticipantOverall

@POST
suspend fun makeRoomPublic(@Header("Authorization") authorization: String?, @Url url: String): GenericOverall
suspend fun makeRoomPublic(@Header("Authorization") authorization: String, @Url url: String): GenericOverall

@DELETE
suspend fun makeRoomPrivate(@Header("Authorization") authorization: String?, @Url url: String): GenericOverall
suspend fun makeRoomPrivate(@Header("Authorization") authorization: String, @Url url: String): GenericOverall

@FormUrlEncoded
@PUT
Expand Down Expand Up @@ -132,4 +132,12 @@ interface NcApiCoroutines {
@Url url: String,
@Body body: RequestBody
): GenericOverall

@FormUrlEncoded
@PUT
suspend fun setPassword2(
@Header("Authorization") authorization: String,
@Url url: String,
@Field("password") password: String
): GenericOverall
}
5 changes: 2 additions & 3 deletions ...c/main/java/com/nextcloud/talk/conversationcreation/ConversationCreationRepositoryImpl.kt
View file
Original file line number Diff line number Diff line change
Expand Up @@ -168,16 +168,15 @@ class ConversationCreationRepositoryImpl(

val result: GenericOverall = if (allow) {
ncApiCoroutines.makeRoomPublic(
credentials,
credentials!!,
url
)
} else {
ncApiCoroutines.makeRoomPrivate(
credentials,
credentials!!,
url
)
}

return result
}
}
4 changes: 3 additions & 1 deletion app/src/main/java/com/nextcloud/talk/conversationinfo/ConversationInfoActivity.kt
View file
Original file line number Diff line number Diff line change
Expand Up @@ -916,7 +916,9 @@ class ConversationInfoActivity :
it,
conversation!!,
spreedCapabilities,
conversationUser
conversationUser,
viewModel,
this
).setupGuestAccess()
}
if (ConversationUtils.isNoteToSelfConversation(conversation!!)) {
Expand Down
119 changes: 49 additions & 70 deletions app/src/main/java/com/nextcloud/talk/conversationinfo/GuestAccessHelper.kt
View file
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,11 @@ import android.util.Log
import android.view.LayoutInflater
import android.view.View
import androidx.appcompat.app.AlertDialog
import androidx.lifecycle.LifecycleOwner
import com.google.android.material.dialog.MaterialAlertDialogBuilder
import com.google.android.material.snackbar.Snackbar
import com.nextcloud.talk.R
import com.nextcloud.talk.conversationinfo.viewmodel.ConversationInfoViewModel
import com.nextcloud.talk.data.user.model.User
import com.nextcloud.talk.databinding.ActivityConversationInfoBinding
import com.nextcloud.talk.databinding.DialogPasswordBinding
Expand All @@ -33,9 +35,10 @@ class GuestAccessHelper(
private val binding: ActivityConversationInfoBinding,
private val conversation: ConversationModel,
private val spreedCapabilities: SpreedCapability,
private val conversationUser: User
private val conversationUser: User,
private val viewModel: ConversationInfoViewModel,
private val lifecycleOwner: LifecycleOwner
) {

private val conversationsRepository = activity.conversationsRepository
private val viewThemeUtils = activity.viewThemeUtils
private val context = activity.context
Expand All @@ -61,19 +64,35 @@ class GuestAccessHelper(
binding.guestAccessView.guestAccessSettingsAllowGuest.setOnClickListener {
val isChecked = binding.guestAccessView.allowGuestsSwitch.isChecked
binding.guestAccessView.allowGuestsSwitch.isChecked = !isChecked
conversationsRepository.allowGuests(
conversation.token!!,
!isChecked
).subscribeOn(Schedulers.io())
.observeOn(AndroidSchedulers.mainThread()).subscribe(AllowGuestsResultObserver())
viewModel.allowGuests(conversation.token, !isChecked)
viewModel.allowGuestsViewState.observe(lifecycleOwner) { uiState ->
when (uiState) {
is ConversationInfoViewModel.AllowGuestsUIState.Success -> {
binding.guestAccessView.allowGuestsSwitch.isChecked = uiState.allow
if (uiState.allow) {
showAllOptions()
} else {
hideAllOptions()
}
}
is ConversationInfoViewModel.AllowGuestsUIState.Error -> {
val exception = uiState.exception
val message = context.getString(R.string.nc_guest_access_allow_failed)
Snackbar.make(binding.root, message, Snackbar.LENGTH_LONG).show()
Log.e(TAG, message, exception)
}
ConversationInfoViewModel.AllowGuestsUIState.None -> {
}
}
}
}

binding.guestAccessView.guestAccessSettingsPasswordProtection.setOnClickListener {
val isChecked = binding.guestAccessView.passwordProtectionSwitch.isChecked
binding.guestAccessView.passwordProtectionSwitch.isChecked = !isChecked
if (isChecked) {
conversationsRepository.password("", conversation.token!!).subscribeOn(Schedulers.io())
.observeOn(AndroidSchedulers.mainThread()).subscribe(PasswordResultObserver(false))
viewModel.setPassword("", conversation.token)
passwordObserver()
} else {
showPasswordDialog()
}
Expand All @@ -85,6 +104,25 @@ class GuestAccessHelper(
}
}

private fun passwordObserver() {
viewModel.passwordViewState.observe(lifecycleOwner) { uiState ->
when (uiState) {
is ConversationInfoViewModel.PasswordUiState.Success -> {
// unused atm
}
is ConversationInfoViewModel.PasswordUiState.Error -> {
val exception = uiState.exception
val message = context.getString(R.string.nc_guest_access_password_failed)
Snackbar.make(binding.root, message, Snackbar.LENGTH_LONG).show()
Log.e(TAG, message, exception)
}
is ConversationInfoViewModel.PasswordUiState.None -> {
// unused atm
}
}
}
}

private fun showPasswordDialog() {
val builder = MaterialAlertDialogBuilder(activity)
builder.apply {
Expand All @@ -94,16 +132,14 @@ class GuestAccessHelper(
setTitle(R.string.nc_guest_access_password_dialog_title)
setPositiveButton(R.string.nc_ok) { _, _ ->
val password = dialogPassword.password.text.toString()
conversationsRepository.password(password, conversation.token!!)
.subscribeOn(Schedulers.io())
.observeOn(AndroidSchedulers.mainThread())
.subscribe(PasswordResultObserver(true))
viewModel.setPassword(password, conversation.token)
}
setNegativeButton(R.string.nc_cancel) { _, _ ->
binding.guestAccessView.passwordProtectionSwitch.isChecked = false
}
}
createDialog(builder)
passwordObserver()
}

private fun createDialog(builder: MaterialAlertDialogBuilder) {
Expand Down Expand Up @@ -143,32 +179,6 @@ class GuestAccessHelper(
}
}

inner class AllowGuestsResultObserver : Observer<ConversationsRepository.AllowGuestsResult> {

private lateinit var allowGuestsResult: ConversationsRepository.AllowGuestsResult

override fun onNext(t: ConversationsRepository.AllowGuestsResult) {
allowGuestsResult = t
}

override fun onError(e: Throwable) {
val message = context.getString(R.string.nc_guest_access_allow_failed)
Snackbar.make(binding.root, message, Snackbar.LENGTH_LONG).show()
Log.e(TAG, message, e)
}

override fun onComplete() {
binding.guestAccessView.allowGuestsSwitch.isChecked = allowGuestsResult.allow
if (allowGuestsResult.allow) {
showAllOptions()
} else {
hideAllOptions()
}
}

override fun onSubscribe(d: Disposable) = Unit
}

private fun showAllOptions() {
binding.guestAccessView.guestAccessSettingsPasswordProtection.visibility = View.VISIBLE
if (conversationUser.capabilities?.spreedCapability?.features?.contains("sip-support") == true) {
Expand All @@ -181,37 +191,6 @@ class GuestAccessHelper(
binding.guestAccessView.resendInvitationsButton.visibility = View.GONE
}

inner class PasswordResultObserver(private val setPassword: Boolean) :
Observer<ConversationsRepository.PasswordResult> {

private lateinit var passwordResult: ConversationsRepository.PasswordResult

override fun onSubscribe(d: Disposable) = Unit

override fun onNext(t: ConversationsRepository.PasswordResult) {
passwordResult = t
}

override fun onError(e: Throwable) {
val message = context.getString(R.string.nc_guest_access_password_failed)
Snackbar.make(binding.root, message, Snackbar.LENGTH_LONG).show()
Log.e(TAG, message, e)
}

override fun onComplete() {
binding.guestAccessView.passwordProtectionSwitch.isChecked = passwordResult.passwordSet && setPassword
if (passwordResult.passwordIsWeak) {
val builder = MaterialAlertDialogBuilder(activity)
builder.apply {
setTitle(R.string.nc_guest_access_password_weak_alert_title)
setMessage(passwordResult.message)
setPositiveButton("OK") { _, _ -> }
}
createDialog(builder)
}
}
}

companion object {
private val TAG = GuestAccessHelper::class.simpleName
}
Expand Down
46 changes: 46 additions & 0 deletions app/src/main/java/com/nextcloud/talk/conversationinfo/viewmodel/ConversationInfoViewModel.kt
View file
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,14 @@
*/
package com.nextcloud.talk.conversationinfo.viewmodel

import android.annotation.SuppressLint
import android.util.Log
import androidx.lifecycle.DefaultLifecycleObserver
import androidx.lifecycle.LifecycleOwner
import androidx.lifecycle.LiveData
import androidx.lifecycle.MutableLiveData
import androidx.lifecycle.ViewModel
import androidx.lifecycle.viewModelScope
import com.nextcloud.talk.chat.data.network.ChatNetworkDataSource
import com.nextcloud.talk.data.user.model.User
import com.nextcloud.talk.models.domain.ConversationModel
Expand All @@ -24,6 +26,7 @@ import io.reactivex.Observer
import io.reactivex.android.schedulers.AndroidSchedulers
import io.reactivex.disposables.Disposable
import io.reactivex.schedulers.Schedulers
import kotlinx.coroutines.launch
import javax.inject.Inject

class ConversationInfoViewModel @Inject constructor(
Expand Down Expand Up @@ -95,6 +98,14 @@ class ConversationInfoViewModel @Inject constructor(
object GetCapabilitiesErrorState : ViewState
open class GetCapabilitiesSuccessState(val spreedCapabilities: SpreedCapability) : ViewState

private val _allowGuestsViewState = MutableLiveData<AllowGuestsUIState>(AllowGuestsUIState.None)
val allowGuestsViewState: LiveData<AllowGuestsUIState>
get() = _allowGuestsViewState

private val _passwordViewState = MutableLiveData<PasswordUiState>(PasswordUiState.None)
val passwordViewState: LiveData<PasswordUiState>
get() = _passwordViewState

private val _getCapabilitiesViewState: MutableLiveData<ViewState> = MutableLiveData(GetCapabilitiesStartState)
val getCapabilitiesViewState: LiveData<ViewState>
get() = _getCapabilitiesViewState
Expand Down Expand Up @@ -233,6 +244,29 @@ class ConversationInfoViewModel @Inject constructor(
})
}

fun allowGuests(token: String, allow: Boolean) {
viewModelScope.launch {
try {
conversationsRepository.allowGuests(token, allow)
_allowGuestsViewState.value = AllowGuestsUIState.Success(allow)
} catch (exception: Exception) {
_allowGuestsViewState.value = AllowGuestsUIState.Error(exception)
}
}
}

@SuppressLint("SuspiciousIndentation")
fun setPassword(password: String, token: String) {
viewModelScope.launch {
try {
conversationsRepository.setPassword(password, token)
_passwordViewState.value = PasswordUiState.Success
} catch (exception: Exception) {
_passwordViewState.value = PasswordUiState.Error(exception)
}
}
}

suspend fun archiveConversation(user: User, token: String) {
val apiVersion = ApiUtils.getConversationApiVersion(user, intArrayOf(ApiUtils.API_V4, ApiUtils.API_V1))
val url = ApiUtils.getUrlForArchive(apiVersion, user.baseUrl, token)
Expand Down Expand Up @@ -267,4 +301,16 @@ class ConversationInfoViewModel @Inject constructor(
companion object {
private val TAG = ConversationInfoViewModel::class.simpleName
}

sealed class AllowGuestsUIState {
data object None : AllowGuestsUIState()
data class Success(val allow: Boolean) : AllowGuestsUIState()
data class Error(val exception: Exception) : AllowGuestsUIState()
}

sealed class PasswordUiState {
data object None : PasswordUiState()
data object Success : PasswordUiState()
data class Error(val exception: Exception) : PasswordUiState()
}
}
16 changes: 3 additions & 13 deletions app/src/main/java/com/nextcloud/talk/repositories/conversations/ConversationsRepository.kt
View file
Original file line number Diff line number Diff line change
Expand Up @@ -12,19 +12,7 @@ import io.reactivex.Observable

interface ConversationsRepository {

data class AllowGuestsResult(
val allow: Boolean
)

fun allowGuests(token: String, allow: Boolean): Observable<AllowGuestsResult>

data class PasswordResult(
val passwordSet: Boolean,
val passwordIsWeak: Boolean,
val message: String
)

fun password(password: String, token: String): Observable<PasswordResult>
suspend fun allowGuests(token: String, allow: Boolean): GenericOverall

data class ResendInvitationsResult(
val successful: Boolean
Expand All @@ -35,5 +23,7 @@ interface ConversationsRepository {

suspend fun unarchiveConversation(credentials: String, url: String): GenericOverall

suspend fun setPassword(password: String, token: String): GenericOverall

fun setConversationReadOnly(credentials: String, url: String, state: Int): Observable<GenericOverall>
}
Loading

0 comments on commit b748080

Please sign in to comment.