feat(Screen): allow to zoom and pan screenshare content #14028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good on a first glance 👍 |
Signed-off-by: Maksim Sukharev <[email protected]>
Signed-off-by: Maksim Sukharev <[email protected]>
Signed-off-by: Maksim Sukharev <[email protected]>
Signed-off-by: Maksim Sukharev <[email protected]>
Antreesy
force-pushed
the
feat/12187/zoom-in-screenshare
branch
from
3330e9c to
107c559
Compare
Antreesy
changed the base branch from
main
to
fix/12187/presenter-overlay-borders
ShGKme
reviewed
Dec 23, 2024
| @@ -182,6 +203,9 @@ export default { | |||
| &--fill { | |||
| object-fit: cover; | |||
| } | |||
| &--magnify { | |||
| cursor: zoom-in; | |||
There was a problem hiding this comment.
zoom-in cursor stays even when the cursor is used to zoom-out or move the image.
There was a problem hiding this comment.
Let's keep the cursor normal and change it on action (e.g: when zooming in -> zoom-in etc)? we can mention that the screen is zoomable/movable in the shortcuts section so user can be informed there
| }) | ||
| }) | ||
| onBeforeUnmount(() => { | ||
| screenPanzoomInstance.value?.dispose() |
There was a problem hiding this comment.
In which case screenPanzoomInstance.value is null/undefined?
There was a problem hiding this comment.
Maybe it's not supposed to be created as long as it's a grid view (although unlikely, as on each screenshare, we switch to speaker view automatically)
Antreesy
force-pushed
the
fix/12187/presenter-overlay-borders
branch
from
9c95b70 to
d6eeb98
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
🖌️ UI Checklist
🖼️ Screenshots / Screencasts
2024-12-23_16h01_36.mp4
🚧 Tasks
🏁 Checklist