feat(conversations): add backend support of compact list #13994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Antreesy
added
3. to review
enhancement
feature: settings ⚙️
Antreesy
force-pushed
the
feat/11697/compact-list-api
branch
from
c335ce4 to
54c7c21
Compare
nickvergessen
requested changes
Dec 16, 2024
lib/Capabilities.php
Outdated
| @@ -229,6 +230,7 @@ public function getCapabilities(): array { | |||
| 'conversations' => [ | |||
| 'can-create' => $user instanceof IUser && !$this->talkConfig->isNotAllowedToCreateConversations($user), | |||
| 'force-passwords' => $this->talkConfig->isPasswordEnforced(), | |||
| 'compact-list' => $this->talkConfig->getConversationsListStyle($user?->getUID()), | |||
There was a problem hiding this comment.
I wondered if a bool is the best option for now, or if we use "string" config already:
Suggested change
| 'compact-list' => $this->talkConfig->getConversationsListStyle($user?->getUID()), | |
| 'list-style' => $this->talkConfig->getConversationsListStyle($user?->getUID()), |
And basically return the strings:
two-linescompact
for now and then we could have other list styles in the future more easily?
There was a problem hiding this comment.
If boolean is already passed as 'yes' or 'no', then I don't see a reason to not do it as you suggesting from the beginning
- int<0,1> was chosen if we further want to extend with other appearance types Signed-off-by: Maksim Sukharev <[email protected]>
Signed-off-by: Maksim Sukharev <[email protected]>
Signed-off-by: Maksim Sukharev <[email protected]>
Antreesy
force-pushed
the
feat/11697/compact-list-api
branch
from
54c7c21 to
cd1caae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
🖌️ UI Checklist
🖼️ Screenshots / Screencasts
🏡 After
🚧 Tasks
🏁 Checklist
🛠️ API Checklist
🚧 Tasks
🏁 Checklist
docs/has been updated or is not required