Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(chat): Add a repair-step to handle the last-read-message=0 case #13951

Merged

Conversation

nickvergessen
Copy link
Member

☑️ Resolves

Repair step doc block

  • In previous versions of Talk, the value 0 was used to mark a chat as
    completely unread. This meant that the next time a client/browser loaded the
    chat it would start all from the beginning. However, there were various
    issues over the time that made the frontend getting null or undefined
    into the wrong place and then accidentally loading 8 years of chat from the
    beginning. So it was agreed that the frontend manually blocks loading with
    last-read-message=0 and the special cases use -2 for this situation.

🛠️ API Checklist

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not possible
  • 📘 API documentation in docs/ has been updated or is not required
  • 🔖 Capability is added or not needed

@nickvergessen nickvergessen added 3. to review feature: chat 💬 Chat and system messages feature: api 🛠️ OCS API for conversations, chats and participants labels Dec 6, 2024
@nickvergessen nickvergessen added this to the 🖤 Next Major (31) milestone Dec 6, 2024
@nickvergessen nickvergessen self-assigned this Dec 6, 2024
@nickvergessen
Copy link
Member Author

/backport to stable30

Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nickvergessen nickvergessen merged commit 058556e into main Dec 9, 2024
71 checks passed
@nickvergessen nickvergessen deleted the bugfix/noid/add-repair-step-for-last-read-message-zero branch December 9, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review feature: api 🛠️ OCS API for conversations, chats and participants feature: chat 💬 Chat and system messages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants