fix(conversations): fix password enforcement logic error #13944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miaulalala
added
3. to review
bug
feature: api 🛠️
DorraJaouad
approved these changes
Dec 5, 2024
nickvergessen
approved these changes
Dec 5, 2024
|
/backport to stable30 |
Signed-off-by: Anna Larch <[email protected]>
miaulalala
force-pushed
the
fix/password-enforcement-logic-error
branch
from
cb81d8d to
ac0bfcc
Compare
| @@ -111,3 +111,9 @@ Feature: chat-2/public | |||
| And user "participant1" renames room "public room" to "A name with 260 chars 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 12345678" with 400 (v4) | |||
| # 255 chars | |||
| And user "participant1" renames room "public room" to "Another name with 255 chars 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 1234567" with 200 (v4) | |||
|
|
|||
| Scenario: Create public room with a password | |||
| When user "participant1" creates room "public room" with 201 (v4) | |||
There was a problem hiding this comment.
also add one where you set the config to "required" and try to create one without sending a password and expect 400?
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
Passwords should be settable on public rooms no matter if the
force_passwordsoptions is set. Only check if a password is set if the option is set totrueand the room is public, but still let public rooms set a password independent from the option.🛠️ API Checklist
🚧 Tasks
🏁 Checklist
docs/has been updated or is not required