Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the message hover position #13888

Closed

Conversation

Simounet
Copy link
Member

πŸ–ŒοΈ UI Checklist

πŸ–ΌοΈ Screenshots / Screencasts

🏚️ Before 🏑 After
message-hover-position-before message-hover-position-after

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Not risky to browser differences / client

Purpose

Being able to get the info from the check icon and send date even when hovering the message. Until now, if it's my first message, I can't be sure if it's the sent or read status.

@Simounet Simounet force-pushed the feat/message-info-hover-position branch from 4b1a358 to 77987df Compare November 27, 2024 21:02
@nickvergessen
Copy link
Member

As easy as it sounds, we had it in the past and reverted it, as it creates flickering and issues when you hover the last message and it's single line. Buttons are cut of, or scrolling misbehaves, etc. πŸ™ˆ
grafik

Ref #9016 and many other things.
So feels quite dangerous.

@Simounet
Copy link
Member Author

I understand you being extra cautious about this sort of "little" things. I saw the video with the flickering but I can't see why it would produce this kind of issue with an absolute position. Did you have other options in mind? To me, actions should not be displayed on hover, hidden from the user.
Should we use the extra space on the right side of the message on desktop view and absolute position be always display on mobile?

@DorraJaouad
Copy link
Contributor

I can't see why it would produce this kind of issue with an absolute position.

Probably because the absolute positioning is relative to its ancestor only (message item).

To me, actions should not be displayed on hover, hidden from the user.

Indeed, it makes it more accessible to keep it shown for user regardless of hover especially for mobile view yet we have the space constraint. As shown below, this is a view from desktop browser and there is no space that fits the message actions :/

Should we use the extra space on the right side of the message on desktop view

The side spaces are not fixed and are adjustable based on window width.

@DorraJaouad
Copy link
Contributor

@Simounet Thank you for taking the time to contribute to our project. I am afraid we're unable to merge this pull request as it would remove a critical workaround we implemented to address the existing flickering issue.

We appreciate your effort and want to provide more context. The current workaround is essential for maintaining the stability of our user experience. If you'd like to understand the specifics of the flickering problem or any other issue, we'd be happy to discuss it in more detail in our public chat.

We would like to invite you to explore our open issues on Talk. Your insights and code contribution are always welcome.

@DorraJaouad DorraJaouad closed this Dec 9, 2024
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: β˜‘οΈ Done
Development

Successfully merging this pull request may close these issues.

3 participants