feat(polls): allow editing of draft polls #13883
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nickvergessen wdyt of adding the validation to the setters in the Poll Entity instead of validating them beforehand? Would make sense, don't you think? |
nickvergessen
added
2. developing
feature: api 🛠️
miaulalala
force-pushed
the
feat/edit-delete-poll-drafts
branch
from
8e473b0 to
9dcf018
Compare
nickvergessen
requested changes
Dec 6, 2024
| @@ -166,6 +166,7 @@ | |||
| * `config => call => start-without-media` (local) - Boolean, whether media should be disabled when starting or joining a conversation | |||
| * `config => call => max-duration` - Integer, maximum call duration in seconds. Please note that this should only be used with system cron and with a reasonable high value, due to the expended duration until the background job ran. | |||
| * `config => call => blur-virtual-background` (local) - Boolean, whether blur background is set by default when joining a conversation | |||
| + `edit-draft-poll` - Whether moderators can edit draft polls | |||
There was a problem hiding this comment.
Move to 21? Or are we backport this? Not sure
There was a problem hiding this comment.
we can backport if you like? It's up to you.
There was a problem hiding this comment.
We never backport here (unless forced, and I see no one forcing here) 🙊
miaulalala
force-pushed
the
feat/edit-delete-poll-drafts
branch
from
2aeb3ef to
0ca00dd
Compare
miaulalala
force-pushed
the
feat/edit-delete-poll-drafts
branch
2 times, most recently
from
f694f53 to
06e4b31
Compare
Signed-off-by: Anna Larch <[email protected]> # The commit message #2 will be skipped: # fixup! feat(polls): allow editing of draft polls
miaulalala
force-pushed
the
feat/edit-delete-poll-drafts
branch
from
4787574 to
03c2260
Compare
| * @see \OCA\Talk\Controller\PollController::createPoll() | ||
| */ | ||
| public function updateDraftPoll(int $pollId, Room $room, Participant $participant, string $question, array $options, int $resultMode, int $maxVotes): DataResponse { | ||
| $proxy = $this->proxy->post( |
There was a problem hiding this comment.
since this will not be part of 20.1 nor 19,
we need to check remote capabilities or add error handling here which does it the old way?
But since drafts are only moderator thing and we don't have federated moderators yet, it's actually never applicable?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
🛠️ API Checklist
🚧 Tasks
🏁 Checklist
docs/has been updated or is not required