fix(ratelimit): Allow to bypass rate-limit from bruteforce allowlist #50234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickvergessen
requested review from
Altahrim and
artonge
and removed request for
a team
nickvergessen
force-pushed
the
bugfix/noid/allow-ratelimit-bypass
branch
from
121ffdb to
9bef113
Compare
come-nc
reviewed
Jan 20, 2025
lib/private/AppFramework/Middleware/Security/RateLimitingMiddleware.php
Outdated
Show resolved
Hide resolved
Merged
come-nc
approved these changes
Jan 21, 2025
nickvergessen
force-pushed
the
bugfix/noid/allow-ratelimit-bypass
branch
2 times, most recently
from
c0bd1f0 to
1bb90af
Compare
artonge
reviewed
Jan 21, 2025
lib/private/AppFramework/Middleware/Security/RateLimitingMiddleware.php
Outdated
Show resolved
Hide resolved
lib/private/AppFramework/Middleware/Security/RateLimitingMiddleware.php
Outdated
Show resolved
Hide resolved
Signed-off-by: Joas Schilling <[email protected]>
nickvergessen
force-pushed
the
bugfix/noid/allow-ratelimit-bypass
branch
from
1bb90af to
9b89f84
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Give an option to allow bruteforce bypass-listed ips to also bypass rate-limits
Checklist