-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Run setup checks by category or class #49978
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Josh <[email protected]>
…it handling Signed-off-by: Josh <[email protected]>
Signed-off-by: Josh <[email protected]>
Signed-off-by: Josh <[email protected]>
63f03c8
to
6221951
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
; | ||
} | ||
|
||
protected function execute(InputInterface $input, OutputInterface $output): int { | ||
$results = $this->setupCheckManager->runAll(); | ||
$limit = $input->getArgument('type'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why call it limit?
$limit = $input->getArgument('type'); | |
$type = $input->getArgument('type'); |
if (substr_count($limit, '\\') > 1) { | ||
$results = $this->setupCheckManager->runClass($limit); | ||
} else { | ||
$results = $this->setupCheckManager->runCategory($limit); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe introducing two distinct flags would make it more straightforward
Summary
This PR adds the ability to run:
Implementation:
network
)Examples:
Run all checks in a specific category - e.g. the
network
related tests:./occ setupchecks network
RESULT:
Run a specific individual check - e.g. the
InternetConnectivity
test:./occ setupcheck OCA\\Settings\\SetupChecks\\InternetConnectivity
RESULT:
If an unrecognized category / class is specified inform the user:
TODO
Checklist