fix: add owner fallback #49827
Draft
fix: add owner fallback #49827
+18
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anna Larch <[email protected]>
miaulalala
requested review from
icewind1991,
solracsf,
SystemKeeper and
artonge
|
/backport to stable28 |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
solracsf
reviewed
Dec 13, 2024
| @@ -384,7 +384,7 @@ private function getPathForNode(Node $node): ?string { | |||
|
|
|||
| $owner = $node->getOwner()?->getUid(); | |||
|
|
|||
| if ($owner !== null) { | |||
| if ($owner !== null && $owner !== '') { | |||
There was a problem hiding this comment.
How can $owner be an empty string here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Anna Larch [email protected]<!--
-->
Summary
TODO
Checklist
Screenshots before/after for front-end changesDocumentation (manuals or wiki) has been updated or is not required