Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(occ): hide sensitive data while config:app:set #49826

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

printminion-co
Copy link
Contributor

Summary

Do not display sensitive values in CLI output.

Before:

./occ config:app:set --value "secret!" --sensitive --type string my_app my_secret_pass        

⚠️ my pass is visible in output as plain text

Config value 'my_secret_pass' for app 'my_app' is now set to 'secret!', stored as string in fast cache

After:

./occ config:app:set --value "secret!" --sensitive --type string my_app my_secret_pass             

☑️ my pass is displayed as <sensitive>

Config value 'my_secret_pass' for app 'my_app' is now set to '<sensitive>', stored as string in fast cache

TODO

  • ...

Checklist

in order to hide sensitive data from logs

Signed-off-by: Misha M.-Kupriyanov <[email protected]>
@printminion-co printminion-co force-pushed the fix/occ_hide_sensitive_values branch from ddbbf71 to e2a5242 Compare December 13, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants