Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable29] fix(files_sharing): Fix error messages from password policy #49823

Closed
wants to merge 1 commit into from

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Dec 12, 2024

Backport of #49361

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Amend HEAD commit to remove the line stating to skip CI

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Exceptions thrown from password_policy may bubble up in share creation

or update when a password is used. Their message is meant to be shown

to the user. This always the case for HintException so we catch that

instead of the subclass GenericShareException.

Signed-off-by: Côme Chilliet <[email protected]>

[skip ci]
@backportbot backportbot bot added bug 3. to review Waiting for reviews labels Dec 12, 2024
@backportbot backportbot bot added this to the Nextcloud 29.0.11 milestone Dec 12, 2024
@come-nc
Copy link
Contributor

come-nc commented Dec 12, 2024

I will backport #49822 instead

@come-nc come-nc closed this Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant