Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dashboard): wish happy birthday #49730

Merged
merged 1 commit into from
Dec 12, 2024
Merged

Conversation

kesselb
Copy link
Contributor

@kesselb kesselb commented Dec 9, 2024

Summary

Screenshot From 2024-12-09 11-04-47

TODO

  • ...

Checklist

@kesselb kesselb added enhancement 3. to review Waiting for reviews labels Dec 9, 2024
@kesselb kesselb added this to the Nextcloud 31 milestone Dec 9, 2024
@kesselb kesselb self-assigned this Dec 9, 2024
@kesselb kesselb added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Dec 9, 2024
@kesselb kesselb marked this pull request as draft December 9, 2024 13:13
@kesselb
Copy link
Contributor Author

kesselb commented Dec 9, 2024

Back to draft: Will add some tests for the dashboard service.

@blizzz
Copy link
Member

blizzz commented Dec 9, 2024

Expected

Hear Nextclouders singing the birthday song

Actual

Silence

scnr

@kesselb kesselb force-pushed the feat/noid/happy-birthday branch 2 times, most recently from c1886f5 to de66e06 Compare December 10, 2024 21:33
Signed-off-by: Daniel Kesselberg <[email protected]>
@kesselb kesselb force-pushed the feat/noid/happy-birthday branch from de66e06 to 4df99d5 Compare December 10, 2024 21:33
@kesselb kesselb added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Dec 10, 2024
@kesselb kesselb marked this pull request as ready for review December 10, 2024 21:54
@kesselb kesselb requested a review from skjnldsv December 12, 2024 20:23
Copy link
Member

@st3iny st3iny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cute 🤗

@kesselb kesselb merged commit 284827a into master Dec 12, 2024
192 checks passed
@kesselb kesselb deleted the feat/noid/happy-birthday branch December 12, 2024 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants