fix(files_sharing): Do not wrap password policy exception into a generic one #49366
+5
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
approved these changes
Nov 19, 2024
lib/private/Share20/Manager.php
Outdated
| } catch (HintException $e) { | ||
| throw new \Exception($e->getHint()); | ||
| } | ||
| $this->dispatcher->dispatchTyped(new ValidatePasswordPolicyEvent($password)); |
There was a problem hiding this comment.
Still disappointed that this is done using exceptions rather than setting property on the even like isValid...
tobiasKaminsky
requested changes
Nov 19, 2024
provokateurin
approved these changes
Nov 19, 2024
I’m out of ideas |
|
Do you need more info how to reproduce it? |
Do you have a full stacktrace for the Exception? (with this PR applied on server side) |
come-nc
force-pushed
the
fix/remove-share-hint-exception-wrapping
branch
from
d0beeed to
900007d
Compare
|
@tobiasKaminsky Can you test again? It should be good now, message should be back and error code should be 400. |
|
This works now without any modification on client side 🎉 |
tobiasKaminsky
approved these changes
Dec 11, 2024
|
@come-nc can we merge this? 💙 |
4 tasks
come-nc
added
4. to release
…ric one Let the controller access the HintException and show the error to the user. Signed-off-by: Côme Chilliet <[email protected]>
This fixes a regression that bad password returned 403 instead of 400 because of previous changes. Signed-off-by: Côme Chilliet <[email protected]>
Signed-off-by: Côme Chilliet <[email protected]>
come-nc
force-pushed
the
fix/remove-share-hint-exception-wrapping
branch
from
cca3072 to
365ff40
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up of #49361
Summary
Let the controller access the HintException and show the error to the user.
Checklist