test: add disabled task type unit test

Signed-off-by: Jana Peper <[email protected]>

apps/files/src/services/ServiceWorker.js

@@ -2,7 +2,7 @@
  * SPDX-FileCopyrightText: 2019 Nextcloud GmbH and Nextcloud contributors
  * SPDX-License-Identifier: AGPL-3.0-or-later
  */
-import { generateUrl, getRootUrl } from '@nextcloud/router'
+import { generateUrl } from '@nextcloud/router'
 import logger from '../logger.ts'
 
 export default () => {
@@ -11,8 +11,7 @@ export default () => {
 		window.addEventListener('load', async () => {
 			try {
 				const url = generateUrl('/apps/files/preview-service-worker.js', {}, { noRewrite: true })
-				const scope = getRootUrl()
-				const registration = await navigator.serviceWorker.register(url, { scope })
+				const registration = await navigator.serviceWorker.register(url, { scope: '/' })
 				logger.debug('SW registered: ', { registration })
 			} catch (error) {
 				logger.error('SW registration failed: ', { error })

core/Command/TaskProcessing/EnabledCommand.php

@@ -0,0 +1,60 @@
+<?php
+/**
+ * SPDX-FileCopyrightText: 2021 Nextcloud GmbH and Nextcloud contributors
+ * SPDX-License-Identifier: AGPL-3.0-or-later
+ */
+namespace OC\Core\Command\TaskProcessing;
+
+use OC\Core\Command\Base;
+use OCP\IConfig;
+use OCP\TaskProcessing\IManager;
+use Symfony\Component\Console\Input\InputArgument;
+use Symfony\Component\Console\Input\InputInterface;
+use Symfony\Component\Console\Output\OutputInterface;
+
+class EnabledCommand extends Base {
+	public function __construct(
+		protected IManager $taskProcessingManager,
+		private IConfig $config,
+	) {
+		parent::__construct();
+	}
+
+	protected function configure() {
+		$this
+			->setName('taskprocessing:task:enabled')
+			->setDescription('Enable or disable a task type')
+			->addArgument(
+				'task-type-id',
+				InputArgument::REQUIRED,
+				'ID of the task type to configure'
+			)
+			->addArgument(
+				'enabled',
+				InputArgument::REQUIRED,
+				'status of the task type availability. Set 1 to enable and 0 to disable.'
+			);
+		parent::configure();
+	}
+
+	protected function execute(InputInterface $input, OutputInterface $output): int {
+		$enabled = (bool)$input->getArgument('enabled');
+		$taskType = $input->getArgument('task-type-id');
+		$json = $this->config->getAppValue('core', 'ai.taskprocessing_type_preferences');
+		if ($json === '') {
+			$taskTypeSettings = [];
+		} else {
+			$taskTypeSettings = json_decode($json, true);
+		}
+		if ($enabled) {
+			$taskTypeSettings[$taskType] = true;
+		} else {
+			$taskTypeSettings[$taskType] = false;
+		}
+
+
+		$this->config->setAppValue('core', 'ai.taskprocessing_type_preferences', json_encode($taskTypeSettings));
+		$this->writeArrayInOutputFormat($input, $output, $taskTypeSettings);
+		return 0;
+	}
+}

core/register_command.php

@@ -147,6 +147,7 @@
 	$application->add(Server::get(Command\FilesMetadata\Get::class));
 
 	$application->add(Server::get(Command\TaskProcessing\GetCommand::class));
+	$application->add(Server::get(Command\TaskProcessing\EnabledCommand::class));
 	$application->add(Server::get(Command\TaskProcessing\ListCommand::class));
 	$application->add(Server::get(Command\TaskProcessing\Statistics::class));
 

lib/composer/composer/autoload_classmap.php

@@ -1263,6 +1263,7 @@
     'OC\\Core\\Command\\SystemTag\\Delete' => $baseDir . '/core/Command/SystemTag/Delete.php',
     'OC\\Core\\Command\\SystemTag\\Edit' => $baseDir . '/core/Command/SystemTag/Edit.php',
     'OC\\Core\\Command\\SystemTag\\ListCommand' => $baseDir . '/core/Command/SystemTag/ListCommand.php',
+    'OC\\Core\\Command\\TaskProcessing\\EnabledCommand' => $baseDir . '/core/Command/TaskProcessing/EnabledCommand.php',
     'OC\\Core\\Command\\TaskProcessing\\GetCommand' => $baseDir . '/core/Command/TaskProcessing/GetCommand.php',
     'OC\\Core\\Command\\TaskProcessing\\ListCommand' => $baseDir . '/core/Command/TaskProcessing/ListCommand.php',
     'OC\\Core\\Command\\TaskProcessing\\Statistics' => $baseDir . '/core/Command/TaskProcessing/Statistics.php',

lib/composer/composer/autoload_psr4.php

@@ -10,5 +10,6 @@
     'OC\\' => array($baseDir . '/lib/private'),
     'OCP\\' => array($baseDir . '/lib/public'),
     'NCU\\' => array($baseDir . '/lib/unstable'),
+    'Bamarni\\Composer\\Bin\\' => array($vendorDir . '/bamarni/composer-bin-plugin/src'),
     '' => array($baseDir . '/lib/private/legacy'),
 );

lib/composer/composer/autoload_static.php

@@ -21,6 +21,10 @@ class ComposerStaticInit749170dad3f5e7f9ca158f5a9f04f6a2
         array (
             'NCU\\' => 4,
         ),
+        'B' => 
+        array (
+            'Bamarni\\Composer\\Bin\\' => 21,
+        ),
     );
 
     public static $prefixDirsPsr4 = array (
@@ -40,6 +44,10 @@ class ComposerStaticInit749170dad3f5e7f9ca158f5a9f04f6a2
         array (
             0 => __DIR__ . '/../../..' . '/lib/unstable',
         ),
+        'Bamarni\\Composer\\Bin\\' => 
+        array (
+            0 => __DIR__ . '/..' . '/bamarni/composer-bin-plugin/src',
+        ),
     );
 
     public static $fallbackDirsPsr4 = array (
@@ -1304,6 +1312,7 @@ class ComposerStaticInit749170dad3f5e7f9ca158f5a9f04f6a2
         'OC\\Core\\Command\\SystemTag\\Delete' => __DIR__ . '/../../..' . '/core/Command/SystemTag/Delete.php',
         'OC\\Core\\Command\\SystemTag\\Edit' => __DIR__ . '/../../..' . '/core/Command/SystemTag/Edit.php',
         'OC\\Core\\Command\\SystemTag\\ListCommand' => __DIR__ . '/../../..' . '/core/Command/SystemTag/ListCommand.php',
+        'OC\\Core\\Command\\TaskProcessing\\EnabledCommand' => __DIR__ . '/../../..' . '/core/Command/TaskProcessing/EnabledCommand.php',
         'OC\\Core\\Command\\TaskProcessing\\GetCommand' => __DIR__ . '/../../..' . '/core/Command/TaskProcessing/GetCommand.php',
         'OC\\Core\\Command\\TaskProcessing\\ListCommand' => __DIR__ . '/../../..' . '/core/Command/TaskProcessing/ListCommand.php',
         'OC\\Core\\Command\\TaskProcessing\\Statistics' => __DIR__ . '/../../..' . '/core/Command/TaskProcessing/Statistics.php',

tests/lib/TaskProcessing/TaskProcessingTest.php

@@ -187,6 +187,8 @@ public function getOptionalOutputShapeEnumValues(): array {
 	}
 }
 
+
+
 class FailingSyncProvider implements IProvider, ISynchronousProvider {
 	public const ERROR_MESSAGE = 'Failure';
 	public function getId(): string {
@@ -387,6 +389,7 @@ public function getExpectedRuntime(): int {
  */
 class TaskProcessingTest extends \Test\TestCase {
 	private IManager $manager;
+	private IManager $disabledTypeManager;
 	private Coordinator $coordinator;
 	private array $providers;
 	private IServerContainer $serverContainer;
@@ -396,6 +399,7 @@ class TaskProcessingTest extends \Test\TestCase {
 	private IJobList $jobList;
 	private IUserMountCache $userMountCache;
 	private IRootFolder $rootFolder;
+	private IConfig $config;
 
 	public const TEST_USER = 'testuser';
 
@@ -442,11 +446,6 @@ protected function setUp(): void {
 		$this->jobList->expects($this->any())->method('add')->willReturnCallback(function () {
 		});
 
-		$config = $this->createMock(IConfig::class);
-		$config->method('getAppValue')
-			->with('core', 'ai.textprocessing_provider_preferences', '')
-			->willReturn('');
-
 		$this->eventDispatcher = $this->createMock(IEventDispatcher::class);
 
 		$text2imageManager = new \OC\TextToImage\Manager(
@@ -460,9 +459,9 @@ protected function setUp(): void {
 		);
 
 		$this->userMountCache = $this->createMock(IUserMountCache::class);
-
+		$this->config = \OC::$server->get(IConfig::class);
 		$this->manager = new Manager(
-			\OC::$server->get(IConfig::class),
+			$this->config,
 			$this->coordinator,
 			$this->serverContainer,
 			\OC::$server->get(LoggerInterface::class),
@@ -492,7 +491,25 @@ public function testShouldNotHaveAnyProviders(): void {
 		$this->manager->scheduleTask(new Task(TextToText::ID, ['input' => 'Hello'], 'test', null));
 	}
 
+	public function testProviderShouldBeRegisteredAndTaskTypeDisabled(): void {
+		$this->registrationContext->expects($this->any())->method('getTaskProcessingProviders')->willReturn([
+			new ServiceRegistration('test', SuccessfulSyncProvider::class)
+		]);
+		$taskProcessingTypeSettings = [
+			TextToText::ID => false,
+		];
+		$this->config->setAppValue('core', 'ai.taskprocessing_type_preferences', json_encode($taskProcessingTypeSettings));
+		$context = $this->coordinator->getRegistrationContext();
+		self::assertCount(0, $this->manager->getAvailableTaskTypes());
+		self::assertCount(1, $this->manager->getAvailableTaskTypes(true));
+		self::assertTrue($this->manager->hasProviders());
+		self::expectException(\OCP\TaskProcessing\Exception\PreConditionNotMetException::class);
+		$this->manager->scheduleTask(new Task(TextToText::ID, ['input' => 'Hello'], 'test', null));
+	}
+
+
 	public function testProviderShouldBeRegisteredAndTaskFailValidation(): void {
+		$this->config->setAppValue('core', 'ai.taskprocessing_type_preferences', '');
 		$this->registrationContext->expects($this->any())->method('getTaskProcessingProviders')->willReturn([
 			new ServiceRegistration('test', BrokenSyncProvider::class)
 		]);