-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(neon_framework): Implement remote wipe #2664
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2664 +/- ##
==========================================
+ Coverage 28.90% 28.95% +0.04%
==========================================
Files 371 371
Lines 136623 136665 +42
==========================================
+ Hits 39491 39569 +78
+ Misses 97132 97096 -36
*This pull request uses carry forward flags. Click here to find out more.
|
9cdbda3
to
0d8711e
Compare
0d8711e
to
6482d21
Compare
Signed-off-by: provokateurin <[email protected]>
Signed-off-by: provokateurin <[email protected]>
Signed-off-by: provokateurin <[email protected]>
Signed-off-by: provokateurin <[email protected]>
6482d21
to
b8eeeec
Compare
Note that this implementation is not per docs, as we only check if the account needs to be wiped once per app start and not for every 401/403 response we receive. |
Closes #43.
Not all data is deleted yet, but that will be fixed in #2114.
Tests for the changes in AccountsBloc still have to be written, but there are no tests for it at all so far, so it is a slightly bigger task than I anticipated.