Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable29] perf: Add index for group_folders table #3527

Draft
wants to merge 2 commits into
base: stable29
Choose a base branch
from
Draft

[stable29] perf: Add index for group_folders table #3527

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
732c447
perf: Add index for group_folders table
provokateurin Oct 29, 2024
63df9b6
fix: Only return $schema if there was changes in migration
come-nc Jan 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 35 additions & 0 deletions lib/Migration/Version19000Date20241029123147.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
<?php

declare(strict_types=1);

/**
* SPDX-FileCopyrightText: 2024 Nextcloud GmbH and Nextcloud contributors
* SPDX-License-Identifier: AGPL-3.0-or-later
*/

namespace OCA\GroupFolders\Migration;

use Closure;
use OCP\DB\ISchemaWrapper;
use OCP\Migration\IOutput;
use OCP\Migration\SimpleMigrationStep;

class Version19000Date20241029123147 extends SimpleMigrationStep {
/**
* @param Closure(): ISchemaWrapper $schemaClosure
*/
public function changeSchema(IOutput $output, Closure $schemaClosure, array $options): ?ISchemaWrapper {
/** @var ISchemaWrapper $schema */
$schema = $schemaClosure();

if ($schema->hasTable('group_folders')) {
$table = $schema->getTable('group_folders');
if (!$table->hasIndex('gf_folders_folder_id')) {
$table->addUniqueIndex(['folder_id'], 'gf_folders_folder_id');
return $schema;
}
}

return null;
}
}