Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check if photo property is set before downloading #4249

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

SebastianKrupinski
Copy link
Contributor

Check if has photo DAV property is set to true before trying to download the photo, to stop 404 errors.

Before:
image

After:
image

Copy link

codecov bot commented Dec 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 11.61%. Comparing base (b91012f) to head (f33c353).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/models/contact.js 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##               main    #4249       +/-   ##
=============================================
- Coverage     66.20%   11.61%   -54.59%     
  Complexity      262      262               
=============================================
  Files            25      117       +92     
  Lines           787     5441     +4654     
  Branches          0     1180     +1180     
=============================================
+ Hits            521      632      +111     
- Misses          266     4687     +4421     
- Partials          0      122      +122     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SebastianKrupinski
Copy link
Contributor Author

/backport to stable6.1

@SebastianKrupinski
Copy link
Contributor Author

/backport to stable6.0

@SebastianKrupinski
Copy link
Contributor Author

/backport to stable5.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
Status: ☑️ Done
Development

Successfully merging this pull request may close these issues.

2 participants