Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PropertySelect: hide PropertySelects with only one selectable option #4092

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

GVodyanov
Copy link
Contributor

Fix #4028

@GVodyanov GVodyanov added the 3. to review Waiting for reviews label Aug 22, 2024
@GVodyanov GVodyanov requested review from st3iny and hamza221 August 22, 2024 11:47
@GVodyanov GVodyanov self-assigned this Aug 22, 2024
Copy link

codecov bot commented Aug 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (a0515f8) to head (3b6088b).

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #4092       +/-   ##
============================================
- Coverage     65.90%   0.00%   -65.91%     
  Complexity      261     261               
============================================
  Files            24      24               
  Lines           786     788        +2     
============================================
- Hits            518       0      -518     
- Misses          268     788      +520     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hamza221
Copy link
Contributor

Just reading the code, I think this would remove any section with a single option, not only addressbook, is it the required behaviour ?

@GVodyanov
Copy link
Contributor Author

Just reading the code, I think this would remove any section with a single option, not only addressbook, is it the required behaviour ?

Yes. But it should make sense for all the other ones. Contact groups are not affected by this. Out of the details we have, this would affect "manager" and "address book"

@SebastianKrupinski
Copy link
Contributor

Works!

@SebastianKrupinski SebastianKrupinski merged commit f422629 into main Oct 8, 2024
24 checks passed
@SebastianKrupinski SebastianKrupinski deleted the enh/hide-useless-selects branch October 8, 2024 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hide address book section if there is only one address book available
3 participants