Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style(ContactsListItem): fix subtitle #4042

Merged
merged 1 commit into from
Jul 22, 2024
Merged

style(ContactsListItem): fix subtitle #4042

merged 1 commit into from
Jul 22, 2024

Conversation

GVodyanov
Copy link
Contributor

Fix #4023

A B
Screenshot from 2024-07-19 15-45-09 Screenshot from 2024-07-19 15-44-25

@GVodyanov GVodyanov added the 2. developing Work in progress label Jul 19, 2024
@GVodyanov GVodyanov requested a review from hamza221 July 19, 2024 13:45
@GVodyanov GVodyanov self-assigned this Jul 19, 2024
@codecov Codecov
Copy link

codecov bot commented Jul 19, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.90%. Comparing base (ccf5399) to head (1b9bc73).

Additional details and impacted files 
@@            Coverage Diff            @@
##               main    #4042   +/-   ##
=========================================
  Coverage     65.90%   65.90%           
  Complexity      261      261           
=========================================
  Files            24       24           
  Lines           786      786           
=========================================
  Hits            518      518           
  Misses          268      268

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GVodyanov
Copy link
Contributor Author

Thanks @hamza221 :)

@GVodyanov GVodyanov marked this pull request as ready for review July 19, 2024 15:06
@hamza221 hamza221 added 4. to release Ready to be released and/or waiting for tests to finish and removed 2. developing Work in progress labels Jul 20, 2024
@GVodyanov GVodyanov force-pushed the fix/contact-list-item-subtitle branch from 4329877 to 1b9bc73 Compare July 22, 2024 07:59
@GVodyanov GVodyanov merged commit 7a75e56 into main Jul 22, 2024
26 checks passed
@GVodyanov GVodyanov deleted the fix/contact-list-item-subtitle branch July 22, 2024 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hamza221 hamza221 hamza221 approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@GretaD GretaD Awaiting requested review from GretaD

Assignees

@GVodyanov GVodyanov

Labels
4. to release Ready to be released and/or waiting for tests to finish
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Lost email address subline in contacts list
3 participants
@GVodyanov @ChristophWurst @hamza221