Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RootNavigation: align submit add new group icon with input #4037

Closed
wants to merge 1 commit into from

Conversation

GVodyanov
Copy link
Contributor

Fix #4031

A B
Screenshot from 2024-07-17 17-09-15 Screenshot from 2024-07-17 17-08-37

I know that the solution isn't the best, but we have a custom icon size in contacts, so the bug isn't related to nextcloud vue

@GVodyanov GVodyanov added the 3. to review Waiting for reviews label Jul 17, 2024
@GVodyanov GVodyanov requested a review from hamza221 July 17, 2024 15:11
@GVodyanov GVodyanov self-assigned this Jul 17, 2024
Copy link

codecov bot commented Jul 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.90%. Comparing base (fa39393) to head (0663f91).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #4037   +/-   ##
=========================================
  Coverage     65.90%   65.90%           
  Complexity      261      261           
=========================================
  Files            24       24           
  Lines           786      786           
=========================================
  Hits            518      518           
  Misses          268      268           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

1 similar comment
Copy link

codecov bot commented Jul 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.90%. Comparing base (fa39393) to head (0663f91).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #4037   +/-   ##
=========================================
  Coverage     65.90%   65.90%           
  Complexity      261      261           
=========================================
  Files            24       24           
  Lines           786      786           
=========================================
  Hits            518      518           
  Misses          268      268           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GVodyanov GVodyanov requested a review from st3iny July 18, 2024 08:12
@@ -492,4 +492,11 @@ $caption-padding: 22px;
width: 100%;
justify-content: start !important;
}

:deep(.button-vue__icon), :deep(.button-vue--icon-only) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The upstream component looks okay-ish here https://nextcloud-vue-components.netlify.app/#/Components/NcActions?id=ncactioninput

image

Why does ours need these tweaks? Is there any other custom style that pushes down the arrow?

@GVodyanov GVodyanov closed this Jul 18, 2024
@GVodyanov
Copy link
Contributor Author

Already fixed (somehow)

@ChristophWurst ChristophWurst deleted the fix/align-add-group-submit branch July 18, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When creating a new group the arrow isn't aligned with the input space
2 participants