Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Add node build job #3686

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

ci: Add node build job #3686

wants to merge 1 commit into from

Conversation

ChristophWurst
Copy link
Member

Add https://github.com/nextcloud/.github/blob/master/workflow-templates/node.yml to prevent #3672 (comment)

This branch is intentionally outdated so we can see failing CI.

Signed-off-by: Christoph Wurst <[email protected]>
@ChristophWurst ChristophWurst added the 2. developing Work in progress label Nov 2, 2023
@ChristophWurst ChristophWurst requested a review from st3iny November 2, 2023 07:23
@ChristophWurst ChristophWurst self-assigned this Nov 2, 2023
Copy link

codecov bot commented Nov 2, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bd206fd) 2.53% compared to head (2191391) 2.07%.
Report is 11 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##            main   #3686      +/-   ##
========================================
- Coverage   2.53%   2.07%   -0.47%     
========================================
  Files         89      89              
  Lines       4374    5358     +984     
  Branches    1097    1498     +401     
========================================
  Hits         111     111              
- Misses      4146    5127     +981     
- Partials     117     120       +3     

see 47 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChristophWurst
Copy link
Member Author

CI passes. @st3iny does it need a specific version of Node?

@st3iny
Copy link
Member

st3iny commented Nov 2, 2023

I just updated node from 20.8 to 20.9 just to be sure but it still fails on my machine with exactly the same version of node.

$ node --version
v20.9.0
$ npm --version
9.9.0
$ npm ci && npm run build
[...]
ERROR in ./src/main.js + 685 modules
Unexpected token (125:16)
|   data() {
|     return {
|       "contacts",
|       // Let's but the loading state to true if circles is enabled
|       loadingCircles: __WEBPACK_MODULE_REFERENCE__441_5b2264656661756c74225d_directImport_asiSafe1__._,

@st3iny
Copy link
Member

st3iny commented Nov 2, 2023

@ChristophWurst It works when applying this patch:

diff --git a/src/views/Contacts.vue b/src/views/Contacts.vue
index 5820dcb4..b76bd916 100644
--- a/src/views/Contacts.vue
+++ b/src/views/Contacts.vue
@@ -138,7 +138,7 @@ export default {
 
 	data() {
 		return {
-			appName,
+			appName: appName,
 
 			// Let's but the loading state to true if circles is enabled
 			loadingCircles: isCirclesEnabled,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. developing Work in progress
Projects
Status: 🏗️ In progress
Development

Successfully merging this pull request may close these issues.

2 participants