Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(socialavatars): Fix HTTP client usage #3681

Merged
merged 1 commit into from
Nov 30, 2023
Merged

fix(socialavatars): Fix HTTP client usage #3681

merged 1 commit into from
Nov 30, 2023

Conversation

ChristophWurst
Copy link
Member

No description provided.

@ChristophWurst ChristophWurst added bug Something isn't working 3. to review Waiting for reviews labels Oct 31, 2023
@ChristophWurst ChristophWurst self-assigned this Oct 31, 2023
@ChristophWurst
Copy link
Member Author

/backport to stable5.4

@codecov
Copy link

codecov bot commented Oct 31, 2023 •
edited
Loading

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (8a6cd9d) 2.06% compared to head (687ab6b) 1.80%.

Files Patch % Lines
lib/Service/Social/DiasporaProvider.php 0.00% 1 Missing ⚠️
lib/Service/Social/FacebookProvider.php 0.00% 1 Missing ⚠️
lib/Service/Social/InstagramProvider.php 0.00% 1 Missing ⚠️
lib/Service/Social/MastodonProvider.php 0.00% 1 Missing ⚠️
lib/Service/Social/TelegramProvider.php 0.00% 1 Missing ⚠️
lib/Service/Social/XingProvider.php 0.00% 1 Missing ⚠️
lib/Service/SocialApiService.php 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##              main   #3681      +/-   ##
==========================================
- Coverage     2.06%   1.80%   -0.27%     
- Complexity       0     261     +261     
==========================================
  Files           89     113      +24     
  Lines         5379    6163     +784     
  Branches      1523    1523              
==========================================
  Hits           111     111              
- Misses        5147    5931     +784     
  Partials       121     121

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

call-me-matt
call-me-matt approved these changes Nov 30, 2023
View reviewed changes
Copy link
Member

@call-me-matt call-me-matt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cannot test at the moment, but code looks fine to me.

@ChristophWurst ChristophWurst force-pushed the fix/socialavatars/fix-http-client-usage branch from d34426f to 687ab6b Compare November 30, 2023 16:19
@ChristophWurst ChristophWurst merged commit 8e016e9 into main Nov 30, 2023
26 of 28 checks passed
@ChristophWurst ChristophWurst deleted the fix/socialavatars/fix-http-client-usage branch November 30, 2023 17:24
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Nov 30, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@call-me-matt call-me-matt call-me-matt approved these changes

@eleith eleith Awaiting requested review from eleith

@hamza221 hamza221 Awaiting requested review from hamza221 hamza221 is a code owner

Assignees

@ChristophWurst ChristophWurst

Labels
3. to review Waiting for reviews bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ChristophWurst @call-me-matt