Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(circles): sort by initiator level and change icons #3665

Merged
merged 1 commit into from
Nov 2, 2023
Merged

feat(circles): sort by initiator level and change icons #3665

merged 1 commit into from
Nov 2, 2023

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Oct 17, 2023 •
edited
Loading

@skjnldsv skjnldsv added enhancement New feature or request 3. to review Waiting for reviews feature: circles labels Oct 17, 2023
@skjnldsv skjnldsv self-assigned this Oct 17, 2023
@skjnldsv skjnldsv mentioned this pull request Oct 17, 2023
Closed
2 tasks
st3iny

This comment was marked as resolved.

Sign in to view

@codecov
Copy link

codecov bot commented Oct 17, 2023 •
edited
Loading

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (9f98bf3) 2.07% compared to head (c707455) 0.00%.
Report is 11 commits behind head on main.

❗ Current head c707455 differs from pull request most recent head 143edd6. Consider uploading reports for the commit 143edd6 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##              main   #3665      +/-   ##
==========================================
- Coverage     2.07%   0.00%   -2.08%     
- Complexity       0     260     +260     
==========================================
  Files           89      24      -65     
  Lines         5354     782    -4572     
  Branches      1492       0    -1492     
==========================================
- Hits           111       0     -111     
+ Misses        5125     782    -4343     
+ Partials       118       0     -118

see 113 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@skjnldsv skjnldsv mentioned this pull request Oct 17, 2023
Merged
GretaD
GretaD approved these changes Nov 2, 2023
View reviewed changes
Copy link
Contributor

@GretaD GretaD left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works

@GretaD GretaD merged commit aa74eb0 into main Nov 2, 2023
25 checks passed
@GretaD GretaD deleted the feat/sort-circles branch November 2, 2023 13:11
@AndyScherzinger AndyScherzinger mentioned this pull request Apr 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@st3iny st3iny st3iny left review comments

@GretaD GretaD GretaD approved these changes

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl

Assignees

@skjnldsv skjnldsv

Labels
3. to review Waiting for reviews enhancement New feature or request feature: circles
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

With new backend logic done, implement changes on the frontend
3 participants
@skjnldsv @st3iny @GretaD