Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix v-model of address book select control #3650

Merged
merged 1 commit into from
Oct 17, 2023
Merged

fix v-model of address book select control #3650

merged 1 commit into from
Oct 17, 2023

Conversation

fuse314
Copy link
Contributor

@fuse314 fuse314 commented Oct 9, 2023

fixes #3611

@st3iny st3iny self-requested a review October 17, 2023 12:22
@st3iny st3iny added bug Something isn't working 3. to review Waiting for reviews feature: contacts labels Oct 17, 2023
@st3iny st3iny added this to the v5.5.0 milestone Oct 17, 2023
Copy link
Member

@st3iny st3iny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works.

Thank you very much :)

@st3iny
Copy link
Member

st3iny commented Oct 17, 2023

/backport to stable5.4

@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (9854dd8) 2.07% compared to head (d1b7efb) 2.07%.
Report is 13 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #3650   +/-   ##
=====================================
  Coverage   2.07%   2.07%           
=====================================
  Files         89      89           
  Lines       5348    5348           
  Branches    1491    1491           
=====================================
  Hits         111     111           
  Misses      5119    5119           
  Partials     118     118           
Files Coverage Δ
.../AppNavigation/Settings/SettingsImportContacts.vue 0.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@st3iny st3iny merged commit 316fafc into nextcloud:main Oct 17, 2023
27 checks passed
@welcome
Copy link

welcome bot commented Oct 17, 2023

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/contacts/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

@fuse314 fuse314 deleted the fix-import-select-address-book branch October 18, 2023 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews backport-request bug Something isn't working feature: contacts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Selection dialogue for address book import always jumps to "Contacts"
2 participants