Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lost contact groups #3628

Merged
merged 1 commit into from
Sep 22, 2023
Merged

Fix lost contact groups #3628

merged 1 commit into from
Sep 22, 2023

Conversation

hamza221
Copy link
Contributor

Fix #3627

@hamza221 hamza221 added bug Something isn't working 3. to review Waiting for reviews labels Sep 22, 2023
@hamza221 hamza221 self-assigned this Sep 22, 2023
@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.26% 🎉

Comparison is base (a9d4ae9) 1.81% compared to head (2bfcd90) 2.07%.

Additional details and impacted files
@@            Coverage Diff             @@
##              main   #3628      +/-   ##
==========================================
+ Coverage     1.81%   2.07%   +0.26%     
==========================================
  Files          113      89      -24     
  Lines         6129    5348     -781     
  Branches      1491    1491              
==========================================
  Hits           111     111              
+ Misses        5900    5119     -781     
  Partials       118     118              
Files Changed Coverage Δ
src/components/ContactDetails.vue 0.00% <0.00%> (ø)

... and 24 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hamza221 hamza221 changed the title Fix lost contacts groups Fix lost contact groups Sep 22, 2023
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reported issue is reproducible on main but not this PR's branch

👍

@hamza221 hamza221 merged commit f873f83 into main Sep 22, 2023
24 of 25 checks passed
@hamza221 hamza221 deleted the Fix/lost-contact-groups branch September 22, 2023 15:01
@hamza221
Copy link
Contributor Author

/backport to stable5.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reopened Issue: Contact groups get lost when editing contacts in Nextcloud Contacts App (even in 5.41)
2 participants