Force disabling single-quote list for type parameter

[skjnldsv]

Fix #1107

---

Debug session with @miaulalala

• https://github.com/mozilla-comm/ical.js/blob/ba8e2522ffd30ffbe65197a96a487689d6e6e9a1/lib/ical/stringify.js#L246
• https://github.com/mozilla-comm/ical.js/blob/ba8e2522ffd30ffbe65197a96a487689d6e6e9a1/lib/ical/stringify.js#L227
• https://github.com/mozilla-comm/ical.js/blob/ba8e2522ffd30ffbe65197a96a487689d6e6e9a1/lib/ical/stringify.js#L132

• contacts/src/store/contacts.js

  Line 356 in e939943

  const vData = contact.vCard.toString()

Impossible to override the stringify.propertyValue as we don't want to do that for all types,

Suggestion: override the toString method and use a regex to force-remove quotes*
/TYPE="([a-zA-Z-,]+)"/gm

[codecov]

Codecov Report

Merging #2632 (b34df2d) into main (67a9da3) will decrease coverage by 50.80%.
The diff coverage is 94.44%.

@@              Coverage Diff              @@
##               main    #2632       +/-   ##
=============================================
- Coverage     68.85%   18.04%   -50.81%     
  Complexity      248      248               
=============================================
  Files            21       97       +76     
  Lines           700     3169     +2469     
  Branches          0      439      +439     
=============================================
+ Hits            482      572       +90     
- Misses          218     2404     +2186     
- Partials          0      193      +193     

Impacted Files	Coverage Δ
...c/components/AppNavigation/GroupNavigationItem.vue	0.00% <ø> (ø)
src/components/ContactsList.vue	0.00% <ø> (ø)
src/store/contacts.js	5.10% <0.00%> (ø)
src/models/contact.js	12.79% <100.00%> (ø)
src/models/rfcProps.js	62.50% <100.00%> (ø)
src/services/updateDesignSet.js	69.23% <100.00%> (ø)
...mponents/ContactDetails/ContactDetailsProperty.vue	0.00% <0.00%> (ø)
src/services/isContactsInteractionEnabled.js	0.00% <0.00%> (ø)
src/store/index.js	80.00% <0.00%> (ø)
src/services/collaborationAutocompletion.js	0.00% <0.00%> (ø)
... and 72 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67a9da3...b34df2d. Read the comment docs.

[miaulalala]

This doesn't solve cases where the type string looks like this: TYPE="HOME","VOICE" but I don't think that this would be RFC compliant in the first place.

[skjnldsv]

Maybe some testing? 🙈

[miaulalala]

Maybe some testing? see_no_evil

tell me how? 😬

[skjnldsv]

Oh wow, we have zero js testing 🙈
If you feel like adding a very basic one to test the src/models/contact.js file

[rexbron]

This is a big quality of life improvement for iOS users, anything that can be done to move it along?

[skjnldsv]

/rebase

[miaulalala]

@skjnldsv I have no ida how to add a testing framework to the app at all. This needs to be done by somebody who has JS dev experience - so, not me.

[moeb98]

Sure, this is fixed? Installed NC 23.0.5 and Contacts 4.1.1... still effect that categories on iOS 15.5 are shown as "HOME or "CELL, etc...

[rexbron]

Sure, this is fixed? Installed NC 23.0.5 and Contacts 4.1.1... still effect that categories on iOS 15.5 are shown as "HOME or "CELL, etc...

What I've noticed is that iOS and the CardDav server will sometimes exchange the old incorrectly quoted label as a custom label. What has worked for me is reapply the mobile lable in the web interface and then immediately trigger a sync on contacts. Very annoying that this bug polluted the database but alas.

[moeb98]

Sure, this is fixed? Installed NC 23.0.5 and Contacts 4.1.1... still effect that categories on iOS 15.5 are shown as "HOME or "CELL, etc...

What I've noticed is that iOS and the CardDav server will sometimes exchange the old incorrectly quoted label as a custom label. What has worked for me is reapply the mobile lable in the web interface and then immediately trigger a sync on contacts. Very annoying that this bug polluted the database but alas.

Hmmm... didn't work on my end (assume you meant the NC web interface... not iCloud, right?). At the same time, this would imply to go through hundreds / thousands of contact labels (depending on your address book size).

If this is due to a polluted database, isn't there an occ command (as a workaround at least)?

[moeb98]

Any ideas / hints?

[OmarWazzan]

@moeb98 Were you able to figure anything out for this?

[moeb98]

Nope, after waiting for any feedback here for a few days, I honestly lost track due to other priorities and rather switched back to the old iCloud sync using NC for calendar only.