Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(PageService): Create index page if folder or subfolders have pages #1574

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

mejo-
Copy link
Member

@mejo- mejo- commented Nov 6, 2024

Fixes the scenario where a folder is missing the index page but one of its subfolders contains pages.

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests

@mejo- mejo- requested review from blizzz and juliusknorr November 6, 2024 14:25
@mejo- mejo- self-assigned this Nov 6, 2024
@mejo- mejo- requested a review from max-nextcloud as a code owner November 6, 2024 14:25
@mejo- mejo- force-pushed the fix/create_index_page branch 2 times, most recently from 5621112 to e502e4c Compare November 6, 2024 15:00
Copy link
Member

@blizzz blizzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remarks

lib/Service/PageService.php Outdated Show resolved Hide resolved
lib/Service/PageService.php Outdated Show resolved Hide resolved
@mejo- mejo- force-pushed the fix/create_index_page branch from e502e4c to 0d24ae1 Compare November 6, 2024 16:29
Fixes the scenario where a folder is missing the index page but
one of its subfolders contains pages.

Signed-off-by: Jonas <[email protected]>
@mejo- mejo- force-pushed the fix/create_index_page branch from 0d24ae1 to 8fc4803 Compare November 6, 2024 16:53
@mejo- mejo- merged commit e6332d3 into main Nov 6, 2024
51 of 53 checks passed
@mejo- mejo- deleted the fix/create_index_page branch November 6, 2024 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ☑️ Done
Development

Successfully merging this pull request may close these issues.

2 participants