fix(Makefile): evaluate composer prerequisits during build

`ifeq (, $(wildcard $(BUILD_TOOLS_DIR)/composer.phar))` is evaluated before any targets are build. Therefore the file still exists. It is only removed later when the `dist-clean` target is build. Use a file prerequisit instead. This is evaluated when the target is build. Signed-off-by: Max <[email protected]>
nextcloud · Sep 26, 2024 · 9cc23e1 · 9cc23e1
1 parent 9f5b289
commit 9cc23e1
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/Makefile b/Makefile
@@ -34,11 +34,11 @@ all: setup-dev lint build test
 setup-dev: composer-install node-modules
 
 # Install build tools
-composer:
-ifeq (, $(wildcard $(BUILD_TOOLS_DIR)/composer.phar))
+composer: $(BUILD_TOOLS_DIR)/composer.phar
+
+$(BUILD_TOOLS_DIR)/composer.phar:
 	mkdir -p $(BUILD_TOOLS_DIR)
 	cd $(BUILD_TOOLS_DIR) && curl -sS https://getcomposer.org/installer | php
-endif
 
 $(BUILD_TOOLS_DIR)/info.xsd:
 	mkdir -p $(BUILD_TOOLS_DIR)