Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BugFix - ThumbnailCacheManager Software rendering doesn't support hardware bitmaps #14270

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

BugFix - ThumbnailCacheManager Software rendering doesn't support hardware bitmaps #14270

wants to merge 1 commit into from

Conversation

alperozturk96
Copy link
Collaborator

@alperozturk96 alperozturk96 commented Dec 30, 2024 •
edited
Loading

  • Tests written, or not not needed

@alperozturk96
fix
6d2a8be 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96 alperozturk96 linked an issue Dec 30, 2024 that may be closed by this pull request
Thumbnail for png images do not show #14265
Closed
4 tasks
@alperozturk96 alperozturk96 mentioned this pull request Dec 30, 2024
Closed
4 tasks
@github-actions GitHub Actions
Copy link

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/14270.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@github-actions GitHub Actions
Copy link

Codacy

Lint

TypemasterPR
Warnings5959
Errors33

SpotBugs

CategoryBaseNew
Bad practice6565
Correctness5858
Dodgy code298298
Experimental11
Internationalization77
Malicious code vulnerability11
Multithreaded correctness77
Performance5353
Security1818
Total508508

@tobiasKaminsky
Copy link
Member

Can you add more info on this?
Maybe we can even write a test with some test images?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobiasKaminsky tobiasKaminsky Awaiting requested review from tobiasKaminsky

@ZetaTom ZetaTom Awaiting requested review from ZetaTom

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
3. to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Thumbnail for png images do not show
2 participants
@alperozturk96 @tobiasKaminsky