Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BugFix - Get Files For Auto Upload #14161

Merged
merged 2 commits into from
Dec 16, 2024
Merged

Conversation

alperozturk96
Copy link
Collaborator

@alperozturk96 alperozturk96 commented Dec 11, 2024

  • Tests written, or not not needed

FilesystemDataProvider.getFilesForUpload → This function returns local paths for auto-upload.

The new function performs the same task. When I pass syncedFolder.localPath, the new function returns the expected result, but the old function returns an empty list.

How to Test

Set up auto-upload. The local path must contain nested folders, and each folder should have files.

Ensure all files are fetched from the given directory, even with subfiles

The correct name collision policy should be applied. For example:
• Ask Every Time or Skip Upload: Files should not be re-uploaded.
• Overwrite: Files should be re-uploaded.

Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Copy link

Codacy

Lint

TypemasterPR
Warnings5959
Errors33

SpotBugs

CategoryBaseNew
Bad practice6565
Correctness5858
Dodgy code299299
Experimental11
Internationalization77
Malicious code vulnerability11
Multithreaded correctness77
Performance5353
Security1818
Total509509

@tobiasKaminsky tobiasKaminsky merged commit 9f7370f into master Dec 16, 2024
20 of 22 checks passed
@tobiasKaminsky tobiasKaminsky deleted the bugfix/get-files-for-upload branch December 16, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants