Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do Not Throw An Exception in SyncOperation #13680

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

alperozturk96
Copy link
Collaborator

@alperozturk96 alperozturk96 commented Oct 2, 2024

  • Tests written, or not not needed

I returned an ACCOUNT_EXCEPTION for testing purposes, and as can be seen in the video, only the capabilities cannot be updated.

cap.mp4

@tobiasKaminsky
Copy link
Member

Accordin to exception message this is to prevent running a sync operation with a file data storage manager on a wrong/null account.
Have you tested such an operation?

@alperozturk96 alperozturk96 marked this pull request as draft October 7, 2024 10:09
@alperozturk96
Copy link
Collaborator Author

Accordin to exception message this is to prevent running a sync operation with a file data storage manager on a wrong/null account. Have you tested such an operation?

I'm not sure what you mean. I tested switching accounts, and the correct FileDataStorageManager was used.

acc_c.mp4

@alperozturk96 alperozturk96 marked this pull request as ready for review October 8, 2024 09:29
@tobiasKaminsky
Copy link
Member

The message you removed:
"Trying to execute a sync operation with a storage manager for an anonymous account"

So you have you tried it with a non-existing account, e.g. during first setup and when removing last account?

@alperozturk96 alperozturk96 force-pushed the dont-throw-exception-in-sync-operation branch from 142aad8 to bfb319b Compare December 11, 2024 10:02
Copy link

Codacy

Lint

TypemasterPR
Warnings5959
Errors33

SpotBugs

CategoryBaseNew
Bad practice6565
Correctness5858
Dodgy code299299
Experimental11
Internationalization77
Malicious code vulnerability11
Multithreaded correctness77
Performance5353
Security1818
Total509509

@alperozturk96
Copy link
Collaborator Author

Accordin to exception message this is to prevent running a sync operation with a file data storage manager on a wrong/null account. Have you tested such an operation?

I logged in and removed the same account. After pressing the back button, the login screen appeared again. Later, I logged in with the same account and created a folder with two files in it. I did not encounter any problems.

@tobiasKaminsky tobiasKaminsky merged commit 83edc19 into master Dec 12, 2024
21 checks passed
@tobiasKaminsky tobiasKaminsky deleted the dont-throw-exception-in-sync-operation branch December 12, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants