Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.29.3 RC1 #13392

Merged
merged 5 commits into from
Aug 9, 2024
Merged

3.29.3 RC1 #13392

merged 5 commits into from
Aug 9, 2024

Conversation

alperozturk96
Copy link
Collaborator

@alperozturk96 alperozturk96 commented Aug 9, 2024

  • Tests written, or not not needed

Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
@alperozturk96 alperozturk96 mentioned this pull request Aug 9, 2024
1 task
Copy link

github-actions bot commented Aug 9, 2024

Lint

Typestable-3.29PR
Warnings7069
Errors33

SpotBugs

CategoryBaseNew
Bad practice6765
Correctness7271
Dodgy code340340
Experimental11
Internationalization77
Multithreaded correctness66
Performance5757
Security1919
Total569566

Copy link

codecov bot commented Aug 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 27.08%. Comparing base (5c9a57a) to head (00604e0).
Report is 64 commits behind head on stable-3.29.

Additional details and impacted files
@@                Coverage Diff                @@
##             stable-3.29   #13392      +/-   ##
=================================================
- Coverage          27.16%   27.08%   -0.09%     
+ Complexity          3303     3301       -2     
=================================================
  Files                634      635       +1     
  Lines              46648    46821     +173     
  Branches            6177     6207      +30     
=================================================
+ Hits               12672    12680       +8     
- Misses             32100    32254     +154     
- Partials            1876     1887      +11     

see 9 files with indirect coverage changes

Signed-off-by: alperozturk <[email protected]>
Copy link

github-actions bot commented Aug 9, 2024

Lint

Typestable-3.29PR
Warnings7069
Errors33

SpotBugs

CategoryBaseNew
Bad practice6765
Correctness7271
Dodgy code340340
Experimental11
Internationalization77
Multithreaded correctness66
Performance5757
Security1919
Total569566

Copy link

github-actions bot commented Aug 9, 2024

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/13392.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@alperozturk96 alperozturk96 enabled auto-merge August 9, 2024 13:44
@alperozturk96 alperozturk96 merged commit 9e5fcc9 into stable-3.29 Aug 9, 2024
19 checks passed
@tobiasKaminsky tobiasKaminsky deleted the bump-to-3.29.3-rc1 branch October 7, 2024 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants