Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(stylelint): fix scripts to be unix-compatible #6418

Merged
merged 2 commits into from
Jan 22, 2025
Merged

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Jan 22, 2025

☑️ Resolves

stylelint src/**/*.vue src/**/*.scss src/**/*.css

https://stylelint.io/user-guide/cli/

You should include quotation marks around file globs

We didn't, so glob patterns were handled on the shell side instead of stylelint, missing a lot of files on Linux, while it works fine on Windows. (** is not recursive by default)

It must be.

stylelint \"src/**/*.vue\" \"src/**/*.scss\" \"src/**/*.css\"

Also fixed all the stylelint issues.

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 3️⃣ Backport to next requested with a Vue 3 upgrade

@ShGKme ShGKme added 3. to review Waiting for reviews technical debt labels Jan 22, 2025
@ShGKme ShGKme self-assigned this Jan 22, 2025
@ShGKme
Copy link
Contributor Author

ShGKme commented Jan 22, 2025

/backport to next

Signed-off-by: Grigorii K. Shartsev <[email protected]>
@susnux susnux merged commit 81aaec2 into master Jan 22, 2025
19 checks passed
@susnux susnux deleted the chore/stylelint branch January 22, 2025 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants