Change the default no-options message #6352
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inform developers that we can use a different default message when there are no options available. Examples: <NcSelect track-by="gid" label="displayName" :options="selectable" :loading="loading" @option:selected="add" @search="lookupGroups" @close="selectable=[]"> <template #no-options> <span /> </template> </NcSelect> Or: <NcSelect track-by="gid" label="displayName" :options="selectable" :loading="loading" @option:selected="add" @search="lookupGroups" @close="selectable=[]"> <template #no-options> <span> No groups </span> </template> </NcSelect> Signed-off-by: zak39 <[email protected]>
zak39
force-pushed
the
doc/no-options-slot-usage-from-dependency
branch
from
c47f8a3 to
5cf6528
Compare
ShGKme
requested changes
Jan 10, 2025
Comment on lines
+552
to
558
| <!-- | ||
| @slot Define the message when there are no options available. | ||
| Default : "No results" | ||
| @see https://vue-select.org/guide/slots.html#improving-the-default-no-options-text | ||
| --> | ||
| {{ t('No results') }} | ||
| </template> |
There was a problem hiding this comment.
According to the vue-styleguidist docs, this is not correct usage of @slots. There is no <slot> element it describes here.
It doesn't change anything in the generated documentation
There was a problem hiding this comment.
Just a few lines below there is
<!-- @slot Any combination of slots from https://vue-select.org/api/slots.html -->The only problem - vue-styleguidist takes variable name as a slot name, which might be not so obvious. But the text says "any of", and the link has the no-options slot as well as all the other slots.
|
Closing for now. Feel free to bump if you have further question/updates. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inform developers that we can use a different default message when there are no options available.
Examples:
Or: