Preserve perspectives when deleting a frame #42
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, when a frame is deleted, the perspectives associated with
that frame is lost. This commit preserves the perspectives by
transferring them to another visible frame when available. Or saving the
perspectives from the last visible frame when emacs is running in daemon
mode so that they may be later restored.
Known Issues:
- When restoring the last visible frame in daemon mode, the previous
activated perspective is not reactivated. This is a deliberate
choice, because saved window configurations does not transfer across
frames ('persp-import' has the same problem), so reactivating the
previously activated frame may inadvertently show a buffer from
another perspective, which is undesirable.
| (cl-loop for name being the hash-keys of from-hash | ||
| when (not (gethash name to-hash)) do | ||
| (puthash name (gethash name from-hash) | ||
| to-hash))) |
There was a problem hiding this comment.
Rather than just ditching the old perspective if there already exists one with the same name, I think we should merge them as best we can.
|
Reviewed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when a frame is deleted, the perspectives associated with
that frame is lost. This commit preserves the perspectives by
transferring them to another visible frame when available. Or saving the
perspectives from the last visible frame when emacs is running in daemon
mode so that they may be later restored.
Known Issues:
activated perspective is not reactivated. This is a deliberate
choice, because saved window configurations does not transfer across
frames ('persp-import' has the same problem), so reactivating the
previously activated frame may inadvertently show a buffer from
another perspective, which is undesirable.
Perspectives lost after last frame is closed when running in daemon mode #41