-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Github Actions Based Deployment #134
Conversation
…warnings; utilising the tooling's recommended approach: https://sass-lang.com/documentation/cli/migrator/)
…number of top-level files
…ependencies to handle new structure
…nfig changes, migrate dayjs to luxon as a shortest path solve for type errors refactor: lexicographically sort meetup json to make it easier to understand what communities exist in a reasonable way
refactor: change variable name to align with ts norms (camel)
note: this commit intentionally includes an incorrect push branch to validate the deployment prior to a merge request being created
@JayRovacsek thanks for providing this PR. This is probably the most urgent PR to address to move to modern deployment methods for GHActions. When I ran this though: git clone https://github.com/JayRovacsek/newwwie.com/
cd newwwie.com
npm i
npm run dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
npm install sass sass-loader@latest
Looks good. Just needs to update the Sass loader version
Also the quickstart instructions should now be:
npm ci
npm run fetchEvents
npm run build
npm run dev
Oh - re; the above; I can create an issue for it, or look to solve for it still, but the deployed artefact won't show the above error - we do need to solve for it to ensure once saas kills v1 we're not impacted |
This PR (un)fortunately also includes a raft of other changes than just the title. To get this deployment working, it was necessary to resolve a range of issues first, This PR should close:
Regarding #119; a range of types were changed on the
types.ts
file associated with events, when spot-checked upstream with meetup, it didn't seem that any fields that were previously marked as possibly null, ever actualised as a null value. Otherwise handing of null values for venue was handled for given I could evidence that as null via NCSG events as a test candidate (or location isn't easy to get Google maps to accept)Notes on changes not directly tied to any of the above:
When assessing this PR, deployed artifacts exist to assist in review;
main
in a later commit (edit: 0cbee4e) to ensure the merge candidate would work within thenewwwie
org. A showcase of the removal of commits being required for the deployment exists in this example where the source still describes an old update to the November Data Coders Group Meetup of 14 people but the deployed instance reflects correctly (at time of writing) 17 people.There is some follow on issues we should consider if this PR is merged:
If resolving the conflicts in this PR with the primary branch, please consider accepting the removal of the
dist
folder as it is no longer requirededit; apologies if the raising of this PR interrupts anyone over the weekend 🙇