Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update link for sidekiq issue #3033

Merged
merged 1 commit into from
Jan 24, 2025
Merged

update link for sidekiq issue #3033

merged 1 commit into from
Jan 24, 2025

Conversation

tannalynn
Copy link
Contributor

the url test was failing with:

  1) Failure:
HealthyUrlsTest#test_all_urls [/opt/hostedtoolcache/Ruby/3.4.1/x64/lib/ruby/gems/3.4.0/gems/minitest-5.3.3/lib/minitest/assertions.rb:129]:
1 URLs were unreachable!

  https://github.com/mperham/sidekiq/issues/5076 - HTTP 404: Not Found
    files: /home/runner/work/newrelic-ruby-agent/newrelic-ruby-agent/lib/new_relic/agent/instrumentation/sidekiq/extensions/delayed_class.rb.
Expected {"https://github.com/mperham/sidekiq/issues/5076" => "HTTP 404: Not Found"} to be empty.

Looks like the link has changed, so i updated it here.

old: https://github.com/mperham/sidekiq/issues/5076
new: https://github.com/sidekiq/sidekiq/issues/5076

Copy link
Contributor

SimpleCov Report

Coverage Threshold
Line 93.59% 93%

Copy link
Contributor

@kaylareopelle kaylareopelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@tannalynn tannalynn merged commit 44af641 into dev Jan 24, 2025
39 checks passed
@tannalynn tannalynn deleted the update_sidekiq_url branch January 24, 2025 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants