Add Redshift active record adapter #3032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tannalynn
commented
Jan 23, 2025
| database = config && config[:database] | ||
| end | ||
| rescue | ||
| NewRelic::Agent.logger.debug("Failed to retrieve ActiveRecord host port and database details for adapter: #{config && config[:adapter]}") |
There was a problem hiding this comment.
I added this rescue here just for extra safety.
I don't think redshift adapters are going to have issues with this, BUT it's also possible people might DIY a redshift adapter, plus there is no way for us to test them all bc there are a lot. So I added this rescue and log message so if an adapter does cause problems, it won't prevent the segment from being created below, it'll simply be missing the info it wasn't able to grab. (and it would have been missing that info anyways since redshift wasn't previously on the adapter list)
tannalynn
requested review from
hannahramadan and
kaylareopelle
as code owners
lib/new_relic/agent/instrumentation/active_record_subscriber.rb
Outdated
Show resolved
Hide resolved
hannahramadan
previously approved these changes
Jan 23, 2025
Co-authored-by: Kayla Reopelle <[email protected]>
Co-authored-by: Kayla Reopelle <[email protected]>
SimpleCov Report
|
kaylareopelle
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We won't record host, port or db name info unless we recognize the adapter. Also for redshift, regular activerecord doesnt work, so you need to use some other gem for a redshift adapter (it looks like there are quite a lot of these for each rails version). It seems pretty consistently to be named redshift on the adapter in those gems though it seems, on the ones i saw at least.
This is the gem i used in my testing https://github.com/pennylane-hq/activerecord-adapter-redshift
closes #2900