Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thread Profile / Backtrace 3.4.0 fixes #2997

Merged
merged 6 commits into from
Dec 20, 2024
Merged

Conversation

kaylareopelle
Copy link
Contributor

@kaylareopelle kaylareopelle commented Dec 17, 2024

Copy link
Contributor

SimpleCov Report

Coverage Threshold
Line 93.86% 93%

@kaylareopelle kaylareopelle changed the title WIP: Thread Profile / Backtrace 3.4.0 fixes Thread Profile / Backtrace 3.4.0 fixes Dec 18, 2024
@kaylareopelle kaylareopelle marked this pull request as ready for review December 18, 2024 20:27
def setup
@single_line = ruby_3_4_0_or_above? ? "irb.rb:69:in 'Kernel#catch'" : "irb.rb:69:in `catch'"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fun instance variable setup!

hannahramadan
hannahramadan previously approved these changes Dec 19, 2024
Copy link
Contributor

@hannahramadan hannahramadan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great thank you! For tests that use the new methods ruby_3_4_0_or_above?, do you think we need to add TODO to remove when 3.3 is dropped similar to the code comment or should the code TODO be enough of a remind to go check out the tests

@kaylareopelle
Copy link
Contributor Author

Looks great thank you! For tests that use the new methods ruby_3_4_0_or_above?, do you think we need to add TODO to remove when 3.3 is dropped similar to the code comment or should the code TODO be enough of a remind to go check out the tests

Great question! If it seems like a TODO would be helpful, I think it's worth including. They're tests that we don't look at often, so I don't think it'd be very bothersome.

@kaylareopelle kaylareopelle merged commit bf0d07e into dev Dec 20, 2024
34 checks passed
@kaylareopelle kaylareopelle deleted the backtrace-3-4-0-fixes branch December 20, 2024 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update BacktraceNode and ThreadProfile classes for Ruby 3.4
3 participants