-
Notifications
You must be signed in to change notification settings - Fork 600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Thread Profile / Backtrace 3.4.0 fixes #2997
Conversation
SimpleCov Report
|
def setup | ||
@single_line = ruby_3_4_0_or_above? ? "irb.rb:69:in 'Kernel#catch'" : "irb.rb:69:in `catch'" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fun instance variable setup!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great thank you! For tests that use the new methods ruby_3_4_0_or_above?
, do you think we need to add TODO to remove when 3.3 is dropped similar to the code comment or should the code TODO be enough of a remind to go check out the tests
Great question! If it seems like a TODO would be helpful, I think it's worth including. They're tests that we don't look at often, so I don't think it'd be very bothersome. |
Closes #2992
CI, passing on the relevant runs: https://github.com/newrelic/newrelic-ruby-agent/actions/runs/12403980066