Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump ruby/setup-ruby and add ruby-3.4.0-rc1 to ci #2996

Merged
merged 2 commits into from
Dec 17, 2024
Merged

Conversation

kaylareopelle
Copy link
Contributor

@kaylareopelle kaylareopelle commented Dec 14, 2024

Adds the first release candidate for Ruby 3.4.0 to the CI.

https://www.ruby-lang.org/en/news/2024/12/12/ruby-3-4-0-rc1-released/

It also bumps the ruby/setup-ruby version for all workflows.

🟢 Passing CI run: https://github.com/newrelic/newrelic-ruby-agent/actions/runs/12382636120

Copy link
Contributor

SimpleCov Report

Coverage Threshold
Line 93.86% 93%

@kaylareopelle
Copy link
Contributor Author

kaylareopelle commented Dec 17, 2024

update -- fixed! see: https://github.com/newrelic/newrelic-ruby-agent/actions/runs/12382636120

🔴 https://github.com/newrelic/newrelic-ruby-agent/actions/runs/12325127208/job/34403919437

Failed on config_file_loading test:

Stopped processing SimpleCov as a previous error not related to SimpleCov has been detected
/opt/hostedtoolcache/Ruby/3.4.0-rc1/x64/lib/ruby/site_ruby/3.4.0+1/bundler/runtime.rb:304:in 'Bundler::Runtime#check_for_activated_spec!': You have already activated date 3.4.1, but your Gemfile requires date 3.3.4. Since date is a default gem, you can either remove your dependency on it or try updating to a newer version of bundler that supports date as a default gem. (Gem::LoadError)
	from /opt/hostedtoolcache/Ruby/3.4.0-rc1/x64/lib/ruby/site_ruby/3.4.0+1/bundler/runtime.rb:25:in 'block in Bundler::Runtime#setup'
	from /opt/hostedtoolcache/Ruby/3.4.0-rc1/x64/lib/ruby/site_ruby/3.4.0+1/bundler/spec_set.rb:155:in 'Array#each'
	from /opt/hostedtoolcache/Ruby/3.4.0-rc1/x64/lib/ruby/site_ruby/3.4.0+1/bundler/spec_set.rb:155:in 'Bundler::SpecSet#each'
	from /opt/hostedtoolcache/Ruby/3.4.0-rc1/x64/lib/ruby/site_ruby/3.4.0+1/bundler/runtime.rb:24:in 'Enumerable#map'
	from /opt/hostedtoolcache/Ruby/3.4.0-rc1/x64/lib/ruby/site_ruby/3.4.0+1/bundler/runtime.rb:24:in 'Bundler::Runtime#setup'
	from /opt/hostedtoolcache/Ruby/3.4.0-rc1/x64/lib/ruby/site_ruby/3.4.0+1/bundler.rb:170:in 'Bundler.setup'
	from /opt/hostedtoolcache/Ruby/3.4.0-rc1/x64/lib/ruby/site_ruby/3.4.0+1/bundler.rb:195:in 'Bundler.require'
	from /home/runner/work/newrelic-ruby-agent/newrelic-ruby-agent/test/multiverse/lib/multiverse/suite.rb:235:in 'block in Multiverse::Suite#ensure_bundle'
	from /home/runner/work/newrelic-ruby-agent/newrelic-ruby-agent/test/multiverse/lib/multiverse/suite.rb:122:in 'Multiverse::Suite#with_potentially_mismatched_bundler'
	from /home/runner/work/newrelic-ruby-agent/newrelic-ruby-agent/test/multiverse/lib/multiverse/suite.rb:234:in 'Multiverse::Suite#ensure_bundle'
	from /home/runner/work/newrelic-ruby-agent/newrelic-ruby-agent/test/multiverse/lib/multiverse/suite.rb:107:in 'Multiverse::Suite#load_dependencies'
	from /home/runner/work/newrelic-ruby-agent/newrelic-ruby-agent/test/multiverse/lib/multiverse/suite.rb:399:in 'block in Multiverse::Suite#execute_child_environment'
	from /home/runner/work/newrelic-ruby-agent/newrelic-ruby-agent/test/multiverse/lib/multiverse/suite.rb:518:in 'block (2 levels) in Multiverse::Suite#with_unbundled_env'
	from /opt/hostedtoolcache/Ruby/3.4.0-rc1/x64/lib/ruby/site_ruby/3.4.0+1/bundler.rb:418:in 'block in Bundler.with_unbundled_env'
	from /opt/hostedtoolcache/Ruby/3.4.0-rc1/x64/lib/ruby/site_ruby/3.4.0+1/bundler.rb:664:in 'Bundler.with_env'
	from /opt/hostedtoolcache/Ruby/3.4.0-rc1/x64/lib/ruby/site_ruby/3.4.0+1/bundler.rb:418:in 'Bundler.with_unbundled_env'
	from /home/runner/work/newrelic-ruby-agent/newrelic-ruby-agent/test/multiverse/lib/multiverse/suite.rb:518:in 'block in Multiverse::Suite#with_unbundled_env'
	from /home/runner/work/newrelic-ruby-agent/newrelic-ruby-agent/test/multiverse/lib/multiverse/suite.rb:122:in 'Multiverse::Suite#with_potentially_mismatched_bundler'
	from /home/runner/work/newrelic-ruby-agent/newrelic-ruby-agent/test/multiverse/lib/multiverse/suite.rb:513:in 'Multiverse::Suite#with_unbundled_env'
	from /home/runner/work/newrelic-ruby-agent/newrelic-ruby-agent/test/multiverse/lib/multiverse/suite.rb:388:in 'Multiverse::Suite#execute_child_environment'
	from /home/runner/work/newrelic-ruby-agent/newrelic-ruby-agent/test/multiverse/lib/multiverse/suite.rb:761:in '<main>'
"config_file_loading" for Envfile entry 0 failed! (exit: pid 88320 exit 1)

@kaylareopelle kaylareopelle marked this pull request as ready for review December 17, 2024 22:58
Copy link
Contributor

@hannahramadan hannahramadan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💎

@kaylareopelle kaylareopelle merged commit a33b673 into dev Dec 17, 2024
148 of 149 checks passed
@kaylareopelle kaylareopelle deleted the ruby-3-4-0-rc1 branch December 17, 2024 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants